[GNC] GnuCash build 5.13

[John Ralls]

All:

I’ve merged Sherlock’s PR and it will be in the next nightly. The build last night failed so I’ve got some investigating to do.

Regards,
John Ralls

> On Oct 6, 2025, at 11:29, Sherlock <sh025622 at gmail.com> wrote:
> 
> John,
> 
> PR: https://github.com/Gnucash/gnucash/pull/2137
> 
> gnc-plugin-page-account-tree.cpp  (not gnc-plugin-page-account-tree.c)
> 
> The fix also appears to address the crash that occurs when switching files or shutting down.
> 
> Note: When files are first saved, changes to the account page are lost because a new Qof session is created without adjusting the registered gui components.  This appears to be a log standing issue to be addressed some other day.
> 
> Regards,
> 
> Sherlock
> 
> 
> On 10/5/25 11:43 PM, Sherlock wrote:
>> John,
>> I'm calling it a night...
>> The issue was introduced in gnc-plugin-page-account-tree.c.  Commenting out lines 773 and 774 appears sufficient.
>> The order of the calls in gnc-file.c is correct.
>> It's the destroy of the tree view preserves the state in a Qof buffer that is written out to the gcm file by the gnc_state_save call.
>> I should have a PR tomorrow.
>> Regards,
>> Sherlock
>> On 10/5/25 2:48 PM, Sherlock wrote:
>>> John,
>>> 
>>> I suspected as much.
>>> 
>>> Regards,
>>> 
>>> Sherlock
>>> 
>>> 
>>> On 10/5/25 2:39 PM, John Ralls wrote:
>>>> Sherlock,
>>>> 
>>>> Sure. I’m eyeball-deep in Windows build problems that I need to sort out so that I can test the fix for the transfer dialog crash.
>>>> 
>>>> Swapping those two lines (there are three locations in gnucash/gnome- utils/gnc-file.c) would be the first thing I’d try.
>>>> 
>>>> Regards,
>>>> John Ralls
>>>> 
>>>> 
>>>>> On Oct 5, 2025, at 2:35 PM, Sherlock Holmes <sh025622 at gmail.com> wrote:
>>>>> 
>>>>> John,
>>>>> 
>>>>> I was able to reproduce the issue after I saw your initial response. Would you like me to take look?  From your description, it sounds like the gnc_state_save needs to be called before the GUI components are destroyed.
>>>>> 
>>>>> Regards,
>>>>> 
>>>>> Sherlock
>>>>> 
>>>>> On 10/5/25 2:27 PM, John Ralls wrote:
>>>>>> Sherlock,
>>>>>> 
>>>>>> It’s real. I reproduced it on GnuCash 5.13. I suspect that it’s another side effect of https://github.com/Gnucash/gnucash/ commit/4c09a0feee698855f095f9729a4856033cbd0522. gnc_state_save is called immediately *after* gnc_close_gui_component_by_session which is supposed to destroy all of the GUI components having the state, thereby relying on the components being leaked.
>>>>>> 
>>>>>> Regards,
>>>>>> John Ralls
>>>>>> 
>>>>>> 
>>>>>>> On Oct 5, 2025, at 2:08 PM, Sherlock <sh025622 at gmail.com> wrote:
>>>>>>> 
>>>>>>> Hi Roger,
>>>>>>> 
>>>>>>> You did not have to install 5.13.  See https://sourceforge.net/ projects/gnucash/files/gnucash%20(stable)/
>>>>>>> 
>>>>>>> The column widths are metadata maintained in the book's .gcm file in the GNC_DATA_HOME directory.  See https://lists.gnucash.org/ wiki/Configuration_Locations
>>>>>>> 
>>>>>>> I suspect when you replaced your PC, you either neglected to restore the GnuCash configuration files or their attributes.
>>>>>>> 
>>>>>>> 
>>>>>>> Regards,
>>>>>>> 
>>>>>>> Sherlock
>>>>>>> 
>>>>>>> 
>>>>>>> On 10/5/25 8:33 AM, Roger Lewry wrote:
>>>>>>>> Hello
>>>>>>>>   I have had to replace my PC and so have had to install build 5.13. I find
>>>>>>>> that this does not remember changes to column widths in my list of accounts
>>>>>>>> whereas build 5.10 on another laptop does. Is this a bug that will be
>>>>>>>> rectified shortly? I cannot see any setting that I can change to give effect
>>>>>>>> to this.
>>>>>>>>   Roger
> 
> _______________________________________________
> gnucash-user mailing list
> gnucash-user at gnucash.org
> To update your subscription preferences or to unsubscribe:
> https://lists.gnucash.org/mailman/listinfo/gnucash-user
> -----
> Please remember to CC this list on all your replies.
> You can do this by using Reply-To-List or Reply-All.