gnucash stable: Multiple changes pushed

John Ralls jralls at code.gnucash.org
Fri Jun 23 17:47:59 EDT 2023


Updated	 via  https://github.com/Gnucash/gnucash/commit/ba7b2606 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/54d0a535 (commit)
	from  https://github.com/Gnucash/gnucash/commit/e98d3534 (commit)



commit ba7b26066ee8313b4580604958ce284950ac06be
Merge: e98d3534ce 54d0a535ab
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Jun 23 14:45:44 2023 -0700

    Merge Simon Arlott's'open-existing-page-not-restoring' into stable.


commit 54d0a535ab5abe2d0910d990e9e2788412d73450
Author: Simon Arlott <sa.me.uk>
Date:   Fri Jun 23 17:18:05 2023 +0100

    [gnc-main-window] Fix null pointer dereference when opening existing pages
    
    When the page already exists in a window then we can't be restoring pages
    so stop checking. The "window" variable will be nullptr if we're trying to
    open the page "in any window".
    
    This bug was introduced in the changes for bug 798564.

diff --git a/gnucash/gnome-utils/gnc-main-window.cpp b/gnucash/gnome-utils/gnc-main-window.cpp
index ea2a3f0239..25eb9460bc 100644
--- a/gnucash/gnome-utils/gnc-main-window.cpp
+++ b/gnucash/gnome-utils/gnc-main-window.cpp
@@ -3189,8 +3189,7 @@ gnc_main_window_open_page (GncMainWindow *window,
 
     if (gnc_main_window_page_exists(page))
     {
-        if (!gnc_main_window_is_restoring_pages (window))
-            gnc_main_window_display_page (page);
+        gnc_main_window_display_page (page);
         return;
     }
 



Summary of changes:
 gnucash/gnome-utils/gnc-main-window.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)



More information about the gnucash-changes mailing list