AUDIT: r17421 - gnucash/trunk/lib/libqof/qof - Add a new function to the gnc_numeric library that converts denominators to exact powers of ten.

[Andreas Köhler]

Hi,

On Mon, 2008-09-01 at 22:09 +0200, Andreas Köhler wrote:
> Hi Charles,
> 
> On Sun, 2008-07-27 at 11:33 -0400, Charles Day wrote:
> > Trac: http://svn.gnucash.org/trac/changeset/17421
> > Log:
> > Add a new function to the gnc_numeric library that converts denominators to exact powers of ten.
> 
> > Modified: gnucash/trunk/lib/libqof/qof/gnc-numeric.c
> > ===================================================================
> > --- gnucash/trunk/lib/libqof/qof/gnc-numeric.c	2008-07-27 15:11:19 UTC (rev 17420)
> > +++ gnucash/trunk/lib/libqof/qof/gnc-numeric.c	2008-07-27 15:33:23 UTC (rev 17421)
> > +  fraction = converted_val.denom;
> > +  if (fraction <= 0)
> > +    return FALSE;
> 
> out of curiosity, what is the reason for disallowing negative
> denominators?  I am not sure whether there is a gnc_numeric API function
> to switch signs of nom and denom safely, but I am sure that doing it is
> possible :-) But maybe the current behavior is actually desired.

I just noticed that ignoring negative denominators means that 1/(-10) is
now printed as "1 * 10", where it was printed as "10.00" before.  Is
that a regression we have to fix or not?

Ciao,
-- andi5

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20080916/496738a2/attachment.bin