[Gnucash-changes] r12186 - gnucash/trunk - Update patch submitting instructions.

Chris Shoemaker chris at cvs.gnucash.org
Tue Dec 27 14:14:07 EST 2005


Author: chris
Date: 2005-12-27 14:14:07 -0500 (Tue, 27 Dec 2005)
New Revision: 12186
Trac: http://svn.gnucash.org/trac/changeset/12186

Modified:
   gnucash/trunk/README.patches
   gnucash/trunk/README.svn
   gnucash/trunk/make-gnucash-patch.in
Log:
Update patch submitting instructions.


Modified: gnucash/trunk/README.patches
===================================================================
--- gnucash/trunk/README.patches	2005-12-27 17:20:19 UTC (rev 12185)
+++ gnucash/trunk/README.patches	2005-12-27 19:14:07 UTC (rev 12186)
@@ -14,16 +14,28 @@
 
   Once you have done some work that you would like to submit, you need
   to send a patch.  There are two ways to submit a patch.  First, if
-  you're using CVS and only made changes to existing CVS files you
+  you're using SVN and only made changes to existing SVN files you
   can generate the patch using:
 
-      cvs -q diff -u > /tmp/mypatch
+      svn diff > /tmp/mypatch
 
-  and send /tmp/mypatch into the developers.  Note that this ONLY WORKS
-  if you have NOT added any new files to the source tree.  If you've
-  added new files then you should use a script called "make-gnucash-patch"
-  to help you create the patch for submission.
+  and send /tmp/mypatch to gnucash-devel at gnucash.org with `[PATCH]'
+  prefixed to the Subject: of the email.  Note that this
+  ONLY WORKS if you have NOT added any new files to the source tree.
 
+  If your patch adds new files, use the `-N' flag to diff between a
+  clean directory and your development directory.  E.g.
+  
+  $ diff -urN {gnucash-pristine} {gnucash-mydevel} > /tmp/mypatch
+
+*******************************************************************
+NOTE: The rest of this file describes an out-of-date utility that has
+not been adapted to SVN.  Don't use it.  
+*******************************************************************
+
+  If you've added new files then you should use a script called
+  "make-gnucash-patch" to help you create the patch for submission.
+
   The script make-gnucash-patch is a perl script provided with the
   gnucash distribution that you can use to create your patch.  The
   rest of this file explains how to use that perl script.

Modified: gnucash/trunk/README.svn
===================================================================
--- gnucash/trunk/README.svn	2005-12-27 17:20:19 UTC (rev 12185)
+++ gnucash/trunk/README.svn	2005-12-27 19:14:07 UTC (rev 12186)
@@ -45,12 +45,12 @@
    to ask. But when in doubt, ask. Even if your change is correct,
    somebody may know a better way to do things.
 
-   If you want other people to review your code before it goes in,
-   you can submit your changes as a patch to gnucash-patches at gnucash.org.
+   Since you want other people to review your code before it goes in,
+   you can submit your changes as a patch to gnucash-devel at gnucash.org.
    See README.patches for details.
 
    If you are making changes to gnucash SVN, you should be subscribed
-   to gnucash-devel at gnucash.org and to gnucash-patches at gnucash.org.
+   to gnucash-devel at gnucash.org and to gnucash-changes at gnucash.org.
    (Subscription address: http://www.gnucash.org/en/lists.phtml)
    gnucash-devel at gnucash.org is a good place to ask about intended
    changes.

Modified: gnucash/trunk/make-gnucash-patch.in
===================================================================
--- gnucash/trunk/make-gnucash-patch.in	2005-12-27 17:20:19 UTC (rev 12185)
+++ gnucash/trunk/make-gnucash-patch.in	2005-12-27 19:14:07 UTC (rev 12186)
@@ -3,8 +3,8 @@
 #
 # This perl script is used to make a patch for your GnuCash
 # development work. All patches should be submitted to the
-# mailing list gnucash-patches at gnucash.org. For more info
-# consult the README.
+# mailing list gnucash-devel at gnucash.org. For more info
+# consult README.patches
 #
 # WARNING: By default, this script will checkout an entire
 # up to date copy of the source tree in ../tmp/gnucash/.
@@ -27,6 +27,8 @@
 $::should_uuencode = 1;
 $::diffcmd = "diff -up";
 
+die "This utility has not been updated to use SVN.  Sorry, just use diff(1).";
+
 my $rcfile = $ENV{"HOME"} . "/.gnucash-patch.rc";
 
 if (-f $rcfile) {



More information about the gnucash-changes mailing list