[Gnucash-changes] * src/app-utils/option-util.c: in lookup_string_option() use

Derek Atkins warlord at cvs.gnucash.org
Wed Feb 16 23:57:56 EST 2005


Log Message:
-----------
	* src/app-utils/option-util.c: in lookup_string_option() use
	  SCM_STRING_CHARS() instead of the older gh guile function.

Tags:
----
gnucash-gnome2-dev

Modified Files:
--------------
    gnucash:
        ChangeLog
    gnucash/src/app-utils:
        option-util.c

Revision Data
-------------
Index: ChangeLog
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/ChangeLog,v
retrieving revision 1.1487.2.172
retrieving revision 1.1487.2.173
diff -LChangeLog -LChangeLog -u -r1.1487.2.172 -r1.1487.2.173
--- ChangeLog
+++ ChangeLog
@@ -1,3 +1,8 @@
+2005-02-16  Derek Atkins  <derek at ihtfp.com>
+
+	* src/app-utils/option-util.c: in lookup_string_option() use
+	  SCM_STRING_CHARS() instead of the older gh guile function.
+
 2005-02-15  Derek Atkins  <derek at ihtfp.com>
 
 	Chris Shoemaker's patch: Avoid use of unitialized values in guid.c.
Index: option-util.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/app-utils/option-util.c,v
retrieving revision 1.19.4.5
retrieving revision 1.19.4.6
diff -Lsrc/app-utils/option-util.c -Lsrc/app-utils/option-util.c -u -r1.19.4.5 -r1.19.4.6
--- src/app-utils/option-util.c
+++ src/app-utils/option-util.c
@@ -42,6 +42,9 @@
   - even though there is a make-text-option on the scheme side,
     gnc_option_db_lookup_string_option() doesn't seem to work for
     those, so I guess there's no way to use make-text-option
+    [ note -- the internal structure of a string option and text option
+      are effectively the same, so the get_string_option() should work
+      just fine on a text option. ]
   - for make-date-option, there seems to be only support for getting,
     not for setting.
 */
@@ -2031,7 +2034,7 @@
     {
       value = scm_call_0(getter);
       if (SCM_STRINGP(value))
-        return gh_scm2newstr(value, NULL);
+        return SCM_STRING_CHARS(value);
     }
   }
 


More information about the gnucash-changes mailing list