[Gnucash-changes] removed comment, because the lookup_string_option() works just fine for

Derek Atkins warlord at cvs.gnucash.org
Thu Feb 17 00:08:54 EST 2005


Log Message:
-----------
 removed comment, because the lookup_string_option() works
just fine for text options.

Tags:
----
gnucash-gnome2-dev

Modified Files:
--------------
    gnucash:
        ChangeLog
    gnucash/src/app-utils:
        option-util.c

Revision Data
-------------
Index: ChangeLog
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/ChangeLog,v
retrieving revision 1.1487.2.173
retrieving revision 1.1487.2.174
diff -LChangeLog -LChangeLog -u -r1.1487.2.173 -r1.1487.2.174
--- ChangeLog
+++ ChangeLog
@@ -2,7 +2,9 @@
 
 	* src/app-utils/option-util.c: in lookup_string_option() use
 	  SCM_STRING_CHARS() instead of the older gh guile function.
-
+	  - removed comment, because the lookup_string_option() works
+	    just fine for text options.
+	
 2005-02-15  Derek Atkins  <derek at ihtfp.com>
 
 	Chris Shoemaker's patch: Avoid use of unitialized values in guid.c.
Index: option-util.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/app-utils/option-util.c,v
retrieving revision 1.19.4.6
retrieving revision 1.19.4.7
diff -Lsrc/app-utils/option-util.c -Lsrc/app-utils/option-util.c -u -r1.19.4.6 -r1.19.4.7
--- src/app-utils/option-util.c
+++ src/app-utils/option-util.c
@@ -39,12 +39,6 @@
 
 /* TODO: 
 
-  - even though there is a make-text-option on the scheme side,
-    gnc_option_db_lookup_string_option() doesn't seem to work for
-    those, so I guess there's no way to use make-text-option
-    [ note -- the internal structure of a string option and text option
-      are effectively the same, so the get_string_option() should work
-      just fine on a text option. ]
   - for make-date-option, there seems to be only support for getting,
     not for setting.
 */


More information about the gnucash-changes mailing list