r16399 - gnucash/trunk/src/engine - Bug#452496: This survived my regular receipt entry session, a whole 30 minutes of light testing. So, more testing is probably good, but ain't that always the case.

Josh Sled jsled at cvs.gnucash.org
Mon Aug 6 21:00:56 EDT 2007


Author: jsled
Date: 2007-08-06 21:00:56 -0400 (Mon, 06 Aug 2007)
New Revision: 16399
Trac: http://svn.gnucash.org/trac/changeset/16399

Modified:
   gnucash/trunk/src/engine/Split.c
Log:
Bug#452496: This survived my regular receipt entry session, a whole 30 minutes of light testing.  So, more testing is probably good, but ain't that always the case.


Modified: gnucash/trunk/src/engine/Split.c
===================================================================
--- gnucash/trunk/src/engine/Split.c	2007-08-07 00:56:40 UTC (rev 16398)
+++ gnucash/trunk/src/engine/Split.c	2007-08-07 01:00:56 UTC (rev 16399)
@@ -551,17 +551,13 @@
        original and new transactions, for the _next_ begin/commit cycle. */
     s->orig_acc = s->acc;
     s->orig_parent = s->parent;
-    qof_instance_mark_clean(QOF_INSTANCE(s));
+    qof_commit_edit_part2(QOF_INSTANCE(s), NULL, NULL, 
+                          (void (*) (QofInstance *)) xaccFreeSplit);
 
-    /* This is because Splits don't call qof_commit_edit(). */
-    qof_instance_set_dirty(QOF_INSTANCE(s->parent));
-
     if (acc) {
         g_object_set(acc, "sort-dirty", TRUE, "balance-dirty", TRUE, NULL);
         xaccAccountRecomputeBalance(acc);
     }
-    if (qof_instance_get_destroying(s))
-        xaccFreeSplit(s);
 }
 
 /* An engine-private helper for completing xaccTransRollbackEdit(). */



More information about the gnucash-changes mailing list