r16409 - gnucash/trunk/src/register/register-gnome - Make right-clicks in registers work like left-clicks plus popup, #339260.

Andreas Köhler andi5 at cvs.gnucash.org
Thu Aug 9 07:35:52 EDT 2007


Author: andi5
Date: 2007-08-09 07:35:49 -0400 (Thu, 09 Aug 2007)
New Revision: 16409
Trac: http://svn.gnucash.org/trac/changeset/16409

Modified:
   gnucash/trunk/src/register/register-gnome/gnucash-sheet.c
Log:
Make right-clicks in registers work like left-clicks plus popup, #339260.

To avoid confusion and possible data loss, the register should focus the
transaction that was right-clicked so that actions chosen from the popup
apply to the one the user probably wanted.  The code was already there
but unused because of missing register sheet popups.


Modified: gnucash/trunk/src/register/register-gnome/gnucash-sheet.c
===================================================================
--- gnucash/trunk/src/register/register-gnome/gnucash-sheet.c	2007-08-09 11:35:45 UTC (rev 16408)
+++ gnucash/trunk/src/register/register-gnome/gnucash-sheet.c	2007-08-09 11:35:49 UTC (rev 16409)
@@ -1288,8 +1288,6 @@
                         return TRUE;
                 case 3:
                         do_popup = (sheet->popup != NULL);
-			if (!do_popup)
-				return FALSE;
                         break;
                 default:
                         return FALSE;
@@ -1340,7 +1338,7 @@
                         gtk_menu_popup(GTK_MENU(sheet->popup), NULL, NULL, NULL,
 				       sheet->popup_data, event->button, event->time);
 
-                return TRUE;
+                return button_1 || do_popup;
         }
 
         /* and finally...process this as a POINTER_TRAVERSE */
@@ -1368,7 +1366,7 @@
         if (do_popup)
 		gtk_menu_popup(GTK_MENU(sheet->popup), NULL, NULL, NULL,
 			       sheet->popup_data, event->button, event->time);
-        return TRUE;
+        return button_1 || do_popup;
 }
 
 gboolean



More information about the gnucash-changes mailing list