gnucash maint: Remove automatch_store_transactions() from import-main-matcher.

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/53b45262 (commit)
	from  https://github.com/Gnucash/gnucash/commit/72f630e8 (commit)



commit 53b4526262111c2cae68625ce352b8c749163969
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Jun 23 14:50:36 2016 -0700

    Remove automatch_store_transactions() from import-main-matcher.
    
    There hasn't been a clist to iterate through since 2002, calling
    gnc_import_TransInfo_refresh_destacc immediately after
    gnc_import_TransInfo_set_destacc(...TRUE) is a no-op, and refresh_model_row
    gets called immediately after run_account_picker_dialog_returns.
    
    As a side benefit this might fix bug 757078.

diff --git a/src/import-export/import-main-matcher.c b/src/import-export/import-main-matcher.c
index 3d60557..414da3e 100644
--- a/src/import-export/import-main-matcher.c
+++ b/src/import-export/import-main-matcher.c
@@ -96,11 +96,6 @@ void on_matcher_help_close_clicked (GtkButton *button, gpointer user_data);
 
 /* Local prototypes */
 static void
-automatch_store_transactions(GNCImportMainMatcher *info,
-                             GtkTreeModel *model,
-                             GtkTreeIter *iter,
-                             GNCImportTransInfo *trans_info);
-static void
 refresh_model_row(GNCImportMainMatcher *gui, GtkTreeModel *model,
                   GtkTreeIter *iter, GNCImportTransInfo *info);
 
@@ -258,14 +253,7 @@ run_account_picker_dialog (GNCImportMainMatcher *info,
                                         old_acc,
                                         &ok_pressed);
     if (ok_pressed)
-    {
-        gnc_import_TransInfo_set_destacc (trans_info,
-                                          new_acc,
-                                          TRUE);
-
-        /* Iterate through the transactions in a given clist to auto match them */
-        automatch_store_transactions(info, model, iter, trans_info);
-    }
+        gnc_import_TransInfo_set_destacc (trans_info, new_acc, TRUE);
 }
 
 static void
@@ -914,20 +902,6 @@ void gnc_gen_trans_list_add_trans_with_ref_id(GNCImportMainMatcher *gui, Transac
     return;
 }/* end gnc_import_add_trans_with_ref_id() */
 
-/* Iterate through the rows of the clist and try to automatch each of them */
-static void
-automatch_store_transactions (GNCImportMainMatcher *info,
-                              GtkTreeModel *model,
-                              GtkTreeIter *iter,
-                              GNCImportTransInfo *trans_info)
-{
-    /* returns TRUE if we changed this row, so update it */
-    if (gnc_import_TransInfo_refresh_destacc(trans_info, NULL))
-    {
-        refresh_model_row(info, model, iter, trans_info);
-    }
-}
-
 GtkWidget *gnc_gen_trans_list_widget (GNCImportMainMatcher *info)
 {
     g_assert(info);



Summary of changes:
 src/import-export/import-main-matcher.c | 28 +---------------------------
 1 file changed, 1 insertion(+), 27 deletions(-)