gnucash unstable: Multiple changes pushed

Geert Janssens gjanssens at code.gnucash.org
Wed Feb 28 10:08:41 EST 2018


Updated	 via  https://github.com/Gnucash/gnucash/commit/fbaa41ac (commit)
	 via  https://github.com/Gnucash/gnucash/commit/cd30578b (commit)
	from  https://github.com/Gnucash/gnucash/commit/c1866241 (commit)



commit fbaa41ac474545c4674582f34c04d2b2eeb43ece
Merge: c186624 cd30578
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Wed Feb 28 15:44:59 2018 +0100

    Merge branch 'register-pref-update' of https://github.com/Bob-IT/gnucash into unstable


commit cd30578b2fb91e9feab29ac38fe461ae54e0f97b
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Fri Feb 23 10:42:47 2018 +0000

    Use the gnc_prefs_get_bool values to update cache values
    
    This way is a safer way to update the cache values in case the settings
    changed signal fails to trigger or there is a double trigger and the
    cached value gets out of sync with the preference value.

diff --git a/gnucash/register/ledger-core/split-register.c b/gnucash/register/ledger-core/split-register.c
index 69c1793..10d5999 100644
--- a/gnucash/register/ledger-core/split-register.c
+++ b/gnucash/register/ledger-core/split-register.c
@@ -2693,11 +2693,13 @@ split_register_pref_changed (gpointer prefs, gchar *pref, gpointer user_data)
     }
     else if (g_str_has_suffix(pref, GNC_PREF_SHOW_LEAF_ACCT_NAMES))
     {
-        reg->show_leaf_accounts = !reg->show_leaf_accounts;
+        reg->show_leaf_accounts = gnc_prefs_get_bool(GNC_PREFS_GROUP_GENERAL_REGISTER,
+                                            GNC_PREF_SHOW_LEAF_ACCT_NAMES);
     }
     else if (g_str_has_suffix(pref, GNC_PREF_ALT_COLOR_BY_TRANS))
     {
-        reg->double_alt_color = !reg->double_alt_color;
+        reg->double_alt_color = gnc_prefs_get_bool(GNC_PREFS_GROUP_GENERAL_REGISTER,
+                                            GNC_PREF_ALT_COLOR_BY_TRANS);
     }
     else
     {



Summary of changes:
 gnucash/register/ledger-core/split-register.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)



More information about the gnucash-changes mailing list