gnucash maint: Multiple changes pushed

Christopher Lam clam at code.gnucash.org
Wed Aug 28 11:37:10 EDT 2019


Updated	 via  https://github.com/Gnucash/gnucash/commit/ca061f06 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/8e2141ce (commit)
	from  https://github.com/Gnucash/gnucash/commit/f00777ca (commit)



commit ca061f066581b6a7d32aa34c139bab7178eb68c7
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Wed Aug 28 19:51:33 2019 +0800

    [test-extras] show better error message if report is not found
    
    this leads to better error messages during test development and other
    work. e.g. a report-module isn't loaded by mistake during a test,
    would formerly lead to a cryptic #f error; this commit ensures the
    uuid cannot be found error is reported.

diff --git a/gnucash/report/report-system/test/test-extras.scm b/gnucash/report/report-system/test/test-extras.scm
index 9f546700d..0354e544f 100644
--- a/gnucash/report/report-system/test/test-extras.scm
+++ b/gnucash/report/report-system/test/test-extras.scm
@@ -40,7 +40,8 @@
   ;; It also dumps the render into /tmp/XX-YY.html where XX is the
   ;; test prefix and YY is the test title.
 
-  (let* ((template (gnc:find-report-template uuid))
+  (let* ((template (or (gnc:find-report-template uuid)
+                       (error "report not found:" uuid)))
          (constructor (record-constructor <report>))
          (report (constructor uuid "bar" options #t #t #f #f ""))
          (renderer (gnc:report-template-renderer template))

commit 8e2141ce672176c69dd80eef9166145474c723f9
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Wed Aug 28 19:53:48 2019 +0800

    [html-utilities] deprecate function

diff --git a/gnucash/report/report-system/html-utilities.scm b/gnucash/report/report-system/html-utilities.scm
index dd569413c..e2b5d5934 100644
--- a/gnucash/report/report-system/html-utilities.scm
+++ b/gnucash/report/report-system/html-utilities.scm
@@ -166,6 +166,8 @@
   ;; instead of html-markup-b, just use the corresponding html-table-styles.
   (define default-style "text-cell")
   (define boldface-style "total-label-cell")
+  (issue-deprecation-warning
+   "gnc:html-acct-table-cell is unused.")
   (gnc:make-html-table-cell/size/markup 
    1 colspan 
    (if boldface? boldface-style default-style)
diff --git a/gnucash/report/report-system/report-system.scm b/gnucash/report/report-system/report-system.scm
index 8fd439e88..68da72afe 100644
--- a/gnucash/report/report-system/report-system.scm
+++ b/gnucash/report/report-system/report-system.scm
@@ -106,7 +106,7 @@
 (export gnc:assign-colors)
 (export gnc:html-table-append-ruler!)
 (export gnc:html-table-append-ruler/markup!)
-(export gnc:html-acct-table-cell)
+(export gnc:html-acct-table-cell)       ;deprecated
 (export gnc:html-acct-table-row-helper! )
 (export gnc:html-acct-table-comm-row-helper!)
 (export gnc:html-build-acct-table)



Summary of changes:
 gnucash/report/report-system/html-utilities.scm   | 2 ++
 gnucash/report/report-system/report-system.scm    | 2 +-
 gnucash/report/report-system/test/test-extras.scm | 3 ++-
 3 files changed, 5 insertions(+), 2 deletions(-)



More information about the gnucash-changes mailing list