gnucash maint: Multiple changes pushed
Robert Fewell
bobit at code.gnucash.org
Thu Aug 29 06:35:43 EDT 2019
Updated via https://github.com/Gnucash/gnucash/commit/d4379644 (commit)
via https://github.com/Gnucash/gnucash/commit/2bcb9bb1 (commit)
via https://github.com/Gnucash/gnucash/commit/d677e3c5 (commit)
via https://github.com/Gnucash/gnucash/commit/251d3947 (commit)
from https://github.com/Gnucash/gnucash/commit/ca061f06 (commit)
commit d4379644c201527e83d83b443d7cda54713513bd
Author: Robert Fewell <14uBobIT at gmail.com>
Date: Thu Aug 29 11:29:23 2019 +0100
Stop duplicate entries for the invoice taxtable cell
When the ledger is loaded, the list for the taxtable combo is created
but as the item_list gui is not initialised yet a temporary list store
is used. This is done twice and hence end up with duplicate entries. To
fix this add the missing gtk_list_store_clear to
gnc_combo_cell_clear_menu to clear the temporary list store when the
item_list is not initialised.
diff --git a/gnucash/register/register-gnome/combocell-gnome.c b/gnucash/register/register-gnome/combocell-gnome.c
index fc8120d8f..eda565a64 100644
--- a/gnucash/register/register-gnome/combocell-gnome.c
+++ b/gnucash/register/register-gnome/combocell-gnome.c
@@ -381,6 +381,8 @@ gnc_combo_cell_clear_menu (ComboCell * cell)
unblock_list_signals (cell);
}
+ else
+ gtk_list_store_clear (box->tmp_store);
}
void
commit 2bcb9bb1a5fa6e2f821836e58b201791e773b032
Author: Robert Fewell <14uBobIT at gmail.com>
Date: Thu Aug 29 11:28:18 2019 +0100
Test for Invoices XML dates not being INT64_MAX
To prevent errors being logged to the trace file when invoices are
saved test for the date values not being INT64_MAX which is an unset
date.
diff --git a/libgnucash/backend/xml/gnc-invoice-xml-v2.cpp b/libgnucash/backend/xml/gnc-invoice-xml-v2.cpp
index b2f45f51f..4bb9ec082 100644
--- a/libgnucash/backend/xml/gnc-invoice-xml-v2.cpp
+++ b/libgnucash/backend/xml/gnc-invoice-xml-v2.cpp
@@ -83,7 +83,7 @@ maybe_add_string (xmlNodePtr ptr, const char* tag, const char* str)
static void
maybe_add_time64 (xmlNodePtr ptr, const char* tag, time64 time)
{
- if (time)
+ if (time != INT64_MAX)
xmlAddChild (ptr, time64_to_dom_tree (tag, time));
}
commit d677e3c5df36d1049d8233001256d070a19bec08
Author: Robert Fewell <14uBobIT at gmail.com>
Date: Thu Aug 29 11:27:10 2019 +0100
Do not log an error when no default tax tables set
diff --git a/libgnucash/engine/gncTaxTable.c b/libgnucash/engine/gncTaxTable.c
index 8fa17d1a0..cbe6aa7af 100644
--- a/libgnucash/engine/gncTaxTable.c
+++ b/libgnucash/engine/gncTaxTable.c
@@ -697,7 +697,6 @@ gncTaxTableGetDefault (QofBook *book, GncOwnerType type)
path = g_slist_prepend (path, (void*)section);
guid = qof_book_get_guid_option (book, path);
- g_return_val_if_fail (guid, NULL);
return gncTaxTableLookup (book, guid);
}
commit 251d39477fb0badfbbc97aec4c7063c9902c3a0e
Author: Robert Fewell <14uBobIT at gmail.com>
Date: Thu Aug 29 11:26:27 2019 +0100
Prevent artefacts of imported transactions from showing
When you start the import process, possible imported transactions are
displayed in the source open register and if you deselect any and press
the OK button you are left with blank lines in the register for those
deselected so move the gnc_gen_trans_list_delete to before the gui
refresh call.
diff --git a/gnucash/import-export/import-main-matcher.c b/gnucash/import-export/import-main-matcher.c
index 0eaf2b88c..b42c497d7 100644
--- a/gnucash/import-export/import-main-matcher.c
+++ b/gnucash/import-export/import-main-matcher.c
@@ -214,10 +214,11 @@ on_matcher_ok_clicked (GtkButton *button, GNCImportMainMatcher *info)
}
while (gtk_tree_model_iter_next (model, &iter));
+ gnc_gen_trans_list_delete (info);
+
/* Allow GUI refresh again. */
gnc_resume_gui_refresh();
- gnc_gen_trans_list_delete (info);
/* DEBUG ("End") */
}
Summary of changes:
gnucash/import-export/import-main-matcher.c | 3 ++-
gnucash/register/register-gnome/combocell-gnome.c | 2 ++
libgnucash/backend/xml/gnc-invoice-xml-v2.cpp | 2 +-
libgnucash/engine/gncTaxTable.c | 1 -
4 files changed, 5 insertions(+), 3 deletions(-)
More information about the gnucash-changes
mailing list