gnucash maint: Multiple changes pushed

[Christopher Lam]

Updated	 via  https://github.com/Gnucash/gnucash/commit/d6f4831a (commit)
	 via  https://github.com/Gnucash/gnucash/commit/e107d861 (commit)
	from  https://github.com/Gnucash/gnucash/commit/4fd6497c (commit)



commit d6f4831a505633bb0bc33a5c003355360603456c
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon Mar 11 20:56:07 2019 +0800

    [commodity-utilities] deprecate gnc:exchange-by-pricedb-helper
    
    this function is unused.

diff --git a/gnucash/report/report-system/commodity-utilities.scm b/gnucash/report/report-system/commodity-utilities.scm
index 5cc3de6c7..fcd373092 100644
--- a/gnucash/report/report-system/commodity-utilities.scm
+++ b/gnucash/report/report-system/commodity-utilities.scm
@@ -794,6 +794,8 @@ construct with gnc:make-gnc-monetary and gnc:monetary->string instead.")
 ;; 'price'. Returns a <gnc:monetary>.
 (define (gnc:exchange-by-pricedb-helper
          foreign domestic price)
+  (issue-deprecation-warning
+   "gnc:exchange-by-pricedb-helper is deprecated.")
   (and (gnc:gnc-monetary? foreign)
        (gnc:make-gnc-monetary
         domestic

commit e107d861d3bdb06c449a10e58a8ca5a6f20e2645
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon Mar 11 20:52:27 2019 +0800

    [commodity-utilities] deprecate gnc:get-commoditylist-inst-prices
    
    This function is "called" by gnc:case-exchange-function when the
    latter is called with parameter 'actual-transactions but the later is
    never used.
    
    To boot it was called with 3 arguments but expects 5. I "fixed" this.
    
    It can be deprecated.

diff --git a/gnucash/report/report-system/commodity-utilities.scm b/gnucash/report/report-system/commodity-utilities.scm
index ddc56546f..5cc3de6c7 100644
--- a/gnucash/report/report-system/commodity-utilities.scm
+++ b/gnucash/report/report-system/commodity-utilities.scm
@@ -319,6 +319,8 @@ construct with gnc:make-gnc-monetary and gnc:monetary->string instead.")
 (define (gnc:get-commoditylist-inst-prices
          commodity-list report-currency end-date
          start-percent delta-percent)
+  (issue-depcrecation-warning
+   "gnc:get-commoditylist-inst-prices is deprecated.")
   (let ((currency-accounts
          (gnc-account-get-descendants-sorted (gnc-get-current-root-account)))
         (work-to-do (length commodity-list))
@@ -940,7 +942,10 @@ construct with gnc:make-gnc-monetary and gnc:monetary->string instead.")
   ;; gnc:get-commodity-inst-prices directly.
     ((actual-transactions) (let ((pricealist
                                   (gnc:get-commoditylist-inst-prices
-                                   commodity-list report-currency to-date-tp)))
+                                   commodity-list report-currency to-date-tp
+                                   start-percent delta-percent)))
+                             (issue-deprecation-warning
+                              "this path is never reached in code.")
                              (lambda (foreign domestic date)
                                (gnc:exchange-by-pricealist-nearest
                                 pricealist foreign domestic date))))



Summary of changes:
 gnucash/report/report-system/commodity-utilities.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)