gnucash maint: Multiple changes pushed

Geert Janssens gjanssens at code.gnucash.org
Thu Oct 17 16:53:13 EDT 2019


Updated	 via  https://github.com/Gnucash/gnucash/commit/1a8c2f28 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/994dcd5d (commit)
	 via  https://github.com/Gnucash/gnucash/commit/e8e18915 (commit)
	from  https://github.com/Gnucash/gnucash/commit/eb37d7f6 (commit)



commit 1a8c2f28012a0a97258794d44164af7514a951c2
Merge: 994dcd5d9 e8e18915e
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Thu Oct 17 22:52:04 2019 +0200

    Merge branch 'editable-fields-posted-invoice' of https://github.com/amishmm/gnucash into maint


commit 994dcd5d9ffed5ae0989bc1c4680a7530ce8e0e9
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Thu Oct 17 22:45:39 2019 +0200

    Remove debugging messages that accidentally had slipped in

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 20ec5ce10..1d1c327b1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -86,8 +86,6 @@ foreach(install_dir ${CMAKE_INSTALL_FULL_BINDIR}
     break()
   endif()
 endforeach()
-message(STATUS "CMAKE_INSTALL_FULL_DATADIR: ${CMAKE_INSTALL_FULL_DATADIR}")
-message(STATUS "DESTDIR: ${DESTDIR}")
 
 # GnuCash installs two files in ${CMAKE_INSTALL_SYSCONFDIR}
 set(BINDIR ${CMAKE_INSTALL_BINDIR} CACHE STRING "user executables")

commit e8e18915ea310319ae794efd8e978588d22f1708
Author: Amish <3330468+amishmm at users.noreply.github.com>
Date:   Tue Sep 10 17:03:46 2019 +0530

    Allow edit of some fields for posted invoice
    
    Allow editing of some fields for posted invoice.
    
    For reasons, see bug report:
    https://bugs.gnucash.org/show_bug.cgi?id=797400
    
    Reverts some changes done to fix:
    https://bugs.gnucash.org/show_bug.cgi?id=797168

diff --git a/gnucash/gnome/dialog-invoice.c b/gnucash/gnome/dialog-invoice.c
index 573293926..aa5e38a5c 100644
--- a/gnucash/gnome/dialog-invoice.c
+++ b/gnucash/gnome/dialog-invoice.c
@@ -1918,13 +1918,13 @@ gnc_invoice_update_window (InvoiceWindow *iw, GtkWidget *widget)
 
         /* Setup viewer for read-only access */
         gtk_widget_set_sensitive (acct_entry, FALSE);
-        gtk_widget_set_sensitive (iw->id_entry, FALSE);
+        gtk_widget_set_sensitive (iw->id_entry, FALSE); /* XXX: why set FALSE and then TRUE? */
         gtk_widget_set_sensitive (iw->id_entry, TRUE);
         gtk_widget_set_sensitive (iw->terms_menu, FALSE);
-        gtk_widget_set_sensitive (iw->owner_box, FALSE);
-        gtk_widget_set_sensitive (iw->job_box, FALSE);
+        gtk_widget_set_sensitive (iw->owner_box, TRUE);
+        gtk_widget_set_sensitive (iw->job_box, TRUE);
         gtk_widget_set_sensitive (iw->billing_id_entry, FALSE);
-        gtk_widget_set_sensitive (iw->notes_text, FALSE); /* XXX: should notes remain writable?*/
+        gtk_widget_set_sensitive (iw->notes_text, TRUE);
     }
     else           /* ! posted */
     {



Summary of changes:
 CMakeLists.txt                 | 2 --
 gnucash/gnome/dialog-invoice.c | 8 ++++----
 2 files changed, 4 insertions(+), 6 deletions(-)



More information about the gnucash-changes mailing list