gnucash maint: Multiple changes pushed

John Ralls jralls at code.gnucash.org
Wed Jan 5 00:10:46 EST 2022


Updated	 via  https://github.com/Gnucash/gnucash/commit/43d4c4a6 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1cbc70bd (commit)
	from  https://github.com/Gnucash/gnucash/commit/100b6fed (commit)



commit 43d4c4a6a305c45528ecea765a098483aa45a46d
Merge: 100b6fed5 1cbc70bd6
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Jan 4 21:08:51 2022 -0800

    Merge Jean Laroche's '798395_ofxdirectconnect_crash' into maint.


commit 1cbc70bd62bceb6fac1ad90e94b733dfe54b3d8e
Author: jean <27791933+jeanlaroche at users.noreply.github.com>
Date:   Mon Jan 3 22:52:59 2022 -0800

    Bug 798395 ofxdirectconnect downloads crash gnucash 4.9
    Add a check of temp_trans_list to avoid dereferencing a NULL pointer when there
    are no transactions to match. Add a dialog to alert the user.

diff --git a/gnucash/import-export/import-main-matcher.c b/gnucash/import-export/import-main-matcher.c
index 0b9e02897..5cd1d5ae2 100644
--- a/gnucash/import-export/import-main-matcher.c
+++ b/gnucash/import-export/import-main-matcher.c
@@ -456,6 +456,11 @@ gnc_gen_trans_list_show_all (GNCImportMainMatcher *info)
     // Set initial state of Append checkbox to same as last import for this account.
     // Get the import account from the first split in first transaction.
     temp_trans_list = info->temp_trans_list;
+    if (!temp_trans_list)
+    {
+        gnc_info_dialog (GTK_WINDOW (info->main_widget), _("While importing transactions found no new transactions."));
+        return;
+    }
     trans_info = temp_trans_list->data;
     first_split = gnc_import_TransInfo_get_fsplit (trans_info);
     account = xaccSplitGetAccount(first_split);



Summary of changes:
 gnucash/import-export/import-main-matcher.c | 5 +++++
 1 file changed, 5 insertions(+)



More information about the gnucash-changes mailing list