gnucash maint: Multiple changes pushed

Robert Fewell bobit at code.gnucash.org
Wed Jan 19 06:02:12 EST 2022


Updated	 via  https://github.com/Gnucash/gnucash/commit/0d8640f7 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1d155931 (commit)
	from  https://github.com/Gnucash/gnucash/commit/863f3c51 (commit)



commit 0d8640f703791262df7e80b61120dc34d3002b84
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Wed Jan 19 11:01:38 2022 +0000

    Update the assistant glade files to clear padding error in trace file.

diff --git a/gnucash/gtkbuilder/assistant-acct-period.glade b/gnucash/gtkbuilder/assistant-acct-period.glade
index b071a306a..938ffdf47 100644
--- a/gnucash/gtkbuilder/assistant-acct-period.glade
+++ b/gnucash/gtkbuilder/assistant-acct-period.glade
@@ -255,9 +255,6 @@ Books will be closed at midnight on the selected date.</property>
       <object class="GtkBox">
         <property name="can-focus">False</property>
       </object>
-      <packing>
-        <property name="has-padding">False</property>
-      </packing>
     </child>
   </object>
 </interface>
diff --git a/gnucash/gtkbuilder/assistant-csv-account-import.glade b/gnucash/gtkbuilder/assistant-csv-account-import.glade
index 4439cc8ab..d1e6184c4 100644
--- a/gnucash/gtkbuilder/assistant-csv-account-import.glade
+++ b/gnucash/gtkbuilder/assistant-csv-account-import.glade
@@ -341,9 +341,6 @@ Cancel to abort.</property>
       <object class="GtkBox">
         <property name="can-focus">False</property>
       </object>
-      <packing>
-        <property name="has-padding">False</property>
-      </packing>
     </child>
   </object>
 </interface>
diff --git a/gnucash/gtkbuilder/assistant-csv-export.glade b/gnucash/gtkbuilder/assistant-csv-export.glade
index ad21f7862..58893a08b 100644
--- a/gnucash/gtkbuilder/assistant-csv-export.glade
+++ b/gnucash/gtkbuilder/assistant-csv-export.glade
@@ -733,9 +733,6 @@ Cancel to abort.</property>
       <object class="GtkBox">
         <property name="can-focus">False</property>
       </object>
-      <packing>
-        <property name="has-padding">False</property>
-      </packing>
     </child>
   </object>
 </interface>
diff --git a/gnucash/gtkbuilder/assistant-csv-price-import.glade b/gnucash/gtkbuilder/assistant-csv-price-import.glade
index a04c9c5da..7f5a94f96 100644
--- a/gnucash/gtkbuilder/assistant-csv-price-import.glade
+++ b/gnucash/gtkbuilder/assistant-csv-price-import.glade
@@ -1063,9 +1063,6 @@ For example
       <object class="GtkBox">
         <property name="can-focus">False</property>
       </object>
-      <packing>
-        <property name="has-padding">False</property>
-      </packing>
     </child>
   </object>
 </interface>
diff --git a/gnucash/gtkbuilder/assistant-csv-trans-import.glade b/gnucash/gtkbuilder/assistant-csv-trans-import.glade
index 92ee821fd..bd58e6ef0 100644
--- a/gnucash/gtkbuilder/assistant-csv-trans-import.glade
+++ b/gnucash/gtkbuilder/assistant-csv-trans-import.glade
@@ -1143,9 +1143,6 @@ More information can be displayed by using the help button.</property>
       <object class="GtkBox">
         <property name="can-focus">False</property>
       </object>
-      <packing>
-        <property name="has-padding">False</property>
-      </packing>
     </child>
   </object>
 </interface>
diff --git a/gnucash/gtkbuilder/assistant-hierarchy.glade b/gnucash/gtkbuilder/assistant-hierarchy.glade
index a57de0256..b11baa8ff 100644
--- a/gnucash/gtkbuilder/assistant-hierarchy.glade
+++ b/gnucash/gtkbuilder/assistant-hierarchy.glade
@@ -590,9 +590,6 @@ Press 'Cancel' to close this dialog without creating any new accounts.</property
       <object class="GtkBox">
         <property name="can-focus">False</property>
       </object>
-      <packing>
-        <property name="has-padding">False</property>
-      </packing>
     </child>
   </object>
 </interface>
diff --git a/gnucash/gtkbuilder/assistant-loan.glade b/gnucash/gtkbuilder/assistant-loan.glade
index 9b9e4ff5a..7564c674c 100644
--- a/gnucash/gtkbuilder/assistant-loan.glade
+++ b/gnucash/gtkbuilder/assistant-loan.glade
@@ -1267,9 +1267,6 @@ Review the details below and if correct press Apply to create the schedule.</pro
       <object class="GtkBox">
         <property name="can-focus">False</property>
       </object>
-      <packing>
-        <property name="has-padding">False</property>
-      </packing>
     </child>
   </object>
 </interface>
diff --git a/gnucash/gtkbuilder/assistant-qif-import.glade b/gnucash/gtkbuilder/assistant-qif-import.glade
index b8f762098..033b8075d 100644
--- a/gnucash/gtkbuilder/assistant-qif-import.glade
+++ b/gnucash/gtkbuilder/assistant-qif-import.glade
@@ -1380,9 +1380,6 @@ Click "Cancel" to abort the QIF import process.</property>
       <object class="GtkBox">
         <property name="can-focus">False</property>
       </object>
-      <packing>
-        <property name="has-padding">False</property>
-      </packing>
     </child>
   </object>
 </interface>
diff --git a/gnucash/gtkbuilder/assistant-stock-split.glade b/gnucash/gtkbuilder/assistant-stock-split.glade
index 6c6acc648..2ea27b049 100644
--- a/gnucash/gtkbuilder/assistant-stock-split.glade
+++ b/gnucash/gtkbuilder/assistant-stock-split.glade
@@ -423,9 +423,6 @@
       <object class="GtkBox">
         <property name="can-focus">False</property>
       </object>
-      <packing>
-        <property name="has-padding">False</property>
-      </packing>
     </child>
   </object>
 </interface>
diff --git a/gnucash/gtkbuilder/assistant-xml-encoding.glade b/gnucash/gtkbuilder/assistant-xml-encoding.glade
index 51933a2b0..eebeb3b8c 100644
--- a/gnucash/gtkbuilder/assistant-xml-encoding.glade
+++ b/gnucash/gtkbuilder/assistant-xml-encoding.glade
@@ -155,9 +155,6 @@
       <object class="GtkBox">
         <property name="can-focus">False</property>
       </object>
-      <packing>
-        <property name="has-padding">False</property>
-      </packing>
     </child>
   </object>
   <object class="GtkDialog" id="encodings_dialog">
diff --git a/gnucash/import-export/aqb/assistant-ab-initial.glade b/gnucash/import-export/aqb/assistant-ab-initial.glade
index 0d414ad3f..1281ac0c2 100644
--- a/gnucash/import-export/aqb/assistant-ab-initial.glade
+++ b/gnucash/import-export/aqb/assistant-ab-initial.glade
@@ -229,9 +229,6 @@ Press "Apply" now.</property>
       <object class="GtkBox">
         <property name="can-focus">False</property>
       </object>
-      <packing>
-        <property name="has-padding">False</property>
-      </packing>
     </child>
   </object>
 </interface>

commit 1d155931c4cd8edb314a01f0aaefef6dd622c07c
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Wed Jan 19 10:37:51 2022 +0000

    Bug 798375 - Transfer Account Selection not editable after typing error
    
    This bug is a result of not using overlayed scrollbars. When the scroll
    bars are not overlayed, additional space is required for the bar and on
    some desktops the use of gtk_widget_set_size_request is needed to
    specify the height of the pop up.
    
    This is only required when the number of entries is low and so the pop
    up height will be less than the available space.

diff --git a/gnucash/register/register-gnome/combocell-gnome.c b/gnucash/register/register-gnome/combocell-gnome.c
index cc1a88c5c..01abe784d 100644
--- a/gnucash/register/register-gnome/combocell-gnome.c
+++ b/gnucash/register/register-gnome/combocell-gnome.c
@@ -929,12 +929,18 @@ popup_get_height (G_GNUC_UNUSED GtkWidget* widget,
 
     if (height < space_available)
     {
-        gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (scrollwin),
-                                        GTK_POLICY_AUTOMATIC, GTK_POLICY_NEVER);
         // if the list is empty height would be 0 so return 1 instead to
         // satisfy the check_popup_height_is_true function
-        return height ? height : 1;
+        gint ret_height = height ? height : 1;
+
+        gtk_widget_set_size_request (GTK_WIDGET(scrollwin), -1, ret_height);
+        gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (scrollwin),
+                                        GTK_POLICY_AUTOMATIC, GTK_POLICY_NEVER);
+        return ret_height;
     }
+    else
+        gtk_widget_set_size_request (GTK_WIDGET(scrollwin), -1, -1);
+
     gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (scrollwin),
                                     GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
     return space_available;



Summary of changes:
 gnucash/gtkbuilder/assistant-acct-period.glade        |  3 ---
 gnucash/gtkbuilder/assistant-csv-account-import.glade |  3 ---
 gnucash/gtkbuilder/assistant-csv-export.glade         |  3 ---
 gnucash/gtkbuilder/assistant-csv-price-import.glade   |  3 ---
 gnucash/gtkbuilder/assistant-csv-trans-import.glade   |  3 ---
 gnucash/gtkbuilder/assistant-hierarchy.glade          |  3 ---
 gnucash/gtkbuilder/assistant-loan.glade               |  3 ---
 gnucash/gtkbuilder/assistant-qif-import.glade         |  3 ---
 gnucash/gtkbuilder/assistant-stock-split.glade        |  3 ---
 gnucash/gtkbuilder/assistant-xml-encoding.glade       |  3 ---
 gnucash/import-export/aqb/assistant-ab-initial.glade  |  3 ---
 gnucash/register/register-gnome/combocell-gnome.c     | 12 +++++++++---
 12 files changed, 9 insertions(+), 36 deletions(-)



More information about the gnucash-changes mailing list