gnucash maint: Fix use-after-free crash in utest-Invoice.

[Christopher Lam]

Updated	 via  https://github.com/Gnucash/gnucash/commit/9f6d495c (commit)
	from  https://github.com/Gnucash/gnucash/commit/e9df8d41 (commit)



commit 9f6d495ca1b37106fca6ec6dd2963b518596e08a
Author: John Ralls <jralls at ceridwen.us>
Date:   Sun Jul 3 13:07:52 2022 -0700

    Fix use-after-free crash in utest-Invoice.

diff --git a/libgnucash/engine/test/utest-Invoice.c b/libgnucash/engine/test/utest-Invoice.c
index d8323a02d..65fe389d1 100644
--- a/libgnucash/engine/test/utest-Invoice.c
+++ b/libgnucash/engine/test/utest-Invoice.c
@@ -86,6 +86,11 @@ teardown( Fixture *fixture, gconstpointer pData )
     gncInvoiceBeginEdit(fixture->invoice);
     gncInvoiceDestroy(fixture->invoice);
 
+    xaccAccountBeginEdit(fixture->account);
+    xaccAccountDestroy(fixture->account);
+    xaccAccountBeginEdit(fixture->account2);
+    xaccAccountDestroy(fixture->account2);
+
     if (data->is_cust_doc)
     {
         gncCustomerBeginEdit(fixture->customer);
@@ -97,10 +102,6 @@ teardown( Fixture *fixture, gconstpointer pData )
         gncVendorDestroy(fixture->vendor);
     }
 
-    xaccAccountBeginEdit(fixture->account);
-    xaccAccountDestroy(fixture->account);
-    xaccAccountBeginEdit(fixture->account2);
-    xaccAccountDestroy(fixture->account2);
     gnc_commodity_destroy(fixture->commodity);
 
     qof_book_destroy( fixture->book );



Summary of changes:
 libgnucash/engine/test/utest-Invoice.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)