gnucash stable: Multiple changes pushed

Robert Fewell bobit at code.gnucash.org
Sun Apr 9 06:58:35 EDT 2023


Updated	 via  https://github.com/Gnucash/gnucash/commit/516c9ed2 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/2fff7b6a (commit)
	from  https://github.com/Gnucash/gnucash/commit/7271ddd1 (commit)



commit 516c9ed2fea63cc96c00ae4deb66d74e2bea611c
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Sun Apr 9 11:39:40 2023 +0100

    Guard against there being no namespaces in the new security dialog

diff --git a/gnucash/gnome-utils/dialog-commodity.c b/gnucash/gnome-utils/dialog-commodity.c
index 55a228b4ac..9386ffb32a 100644
--- a/gnucash/gnome-utils/dialog-commodity.c
+++ b/gnucash/gnome-utils/dialog-commodity.c
@@ -643,8 +643,10 @@ gnc_ui_update_namespace_picker (GtkWidget *cbwe,
     }
 
     if (!matched)
-        gtk_tree_model_get_iter_first(model, &match);
-    gtk_combo_box_set_active_iter(combo_box, &match);
+        matched = gtk_tree_model_get_iter_first (model, &match);
+
+    if (matched)
+        gtk_combo_box_set_active_iter (combo_box, &match);
     g_list_free(namespaces);
 }
 

commit 2fff7b6a14eca005a1420b56d4e1877a0326d908
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Sun Apr 9 11:37:03 2023 +0100

    Fix some menu labels that are not marked for translation

diff --git a/gnucash/ui/gnc-embedded-register-window.ui b/gnucash/ui/gnc-embedded-register-window.ui
index b65bf3ad2e..37a8921bee 100644
--- a/gnucash/ui/gnc-embedded-register-window.ui
+++ b/gnucash/ui/gnc-embedded-register-window.ui
@@ -74,7 +74,7 @@
       </section>
     </submenu>
     <submenu>
-      <attribute name="label" translatable="no">_View</attribute>
+      <attribute name="label" translatable="yes">_View</attribute>
       <attribute name="action">embeddedwin.ViewAction</attribute>
       <section>
         <item>
diff --git a/gnucash/ui/gnc-plugin-page-account-tree.ui b/gnucash/ui/gnc-plugin-page-account-tree.ui
index 1284e45259..a18edc4195 100644
--- a/gnucash/ui/gnc-plugin-page-account-tree.ui
+++ b/gnucash/ui/gnc-plugin-page-account-tree.ui
@@ -141,7 +141,7 @@
       <attribute name="temp" translatable="no">yes</attribute>
     </item>
     <item>
-      <attribute name="label" translatable="no">Stock Ass_istant…</attribute>
+      <attribute name="label" translatable="yes">Stock Ass_istant…</attribute>
       <attribute name="action">GncPluginPageAccountTreeActions.ActionsStockAssistantAction</attribute>
       <attribute name="tooltip" translatable="yes">Stock Assistant</attribute>
       <attribute name="temp" translatable="no">yes</attribute>
@@ -178,7 +178,7 @@
         <attribute name="tempx" translatable="no">yes</attribute>
       </item>
       <item>
-        <attribute name="label" translatable="no">Check & Repair A_ll</attribute>
+        <attribute name="label" translatable="yes">Check & Repair A_ll</attribute>
         <attribute name="action">GncPluginPageAccountTreeActions.ScrubAllAction</attribute>
         <attribute name="tooltip" translatable="yes">Check for and repair unbalanced transactions and orphan splits in all accounts</attribute>
         <attribute name="tempx" translatable="no">yes</attribute>
@@ -246,7 +246,7 @@
         <attribute name="tooltip" translatable="yes">Transfer funds from one account to another</attribute>
       </item>
       <item>
-        <attribute name="label" translatable="no">Stock Ass_istant…</attribute>
+        <attribute name="label" translatable="yes">Stock Ass_istant…</attribute>
         <attribute name="action">GncPluginPageAccountTreeActions.ActionsStockAssistantAction</attribute>
         <attribute name="tooltip" translatable="yes">Stock Assistant</attribute>
       </item>
diff --git a/gnucash/ui/gnc-plugin-page-invoice.ui b/gnucash/ui/gnc-plugin-page-invoice.ui
index 810a19a82d..938cca6e4f 100644
--- a/gnucash/ui/gnc-plugin-page-invoice.ui
+++ b/gnucash/ui/gnc-plugin-page-invoice.ui
@@ -204,7 +204,7 @@
 
   <menu id="ReportsPlaceholder1">
     <item>
-      <attribute name="label" translatable="no">_Company Report</attribute>
+      <attribute name="label" translatable="yes">_Company Report</attribute>
       <attribute name="action">GncPluginPageInvoiceActions.ReportsCompanyReportAction</attribute>
       <attribute name="tooltip" translatable="yes">Open a company report window for the owner of this invoice</attribute>
       <attribute name="temp" translatable="no">yes</attribute>
diff --git a/gnucash/ui/gnc-plugin-page-owner-tree.ui b/gnucash/ui/gnc-plugin-page-owner-tree.ui
index dd0c1a7051..635355323c 100644
--- a/gnucash/ui/gnc-plugin-page-owner-tree.ui
+++ b/gnucash/ui/gnc-plugin-page-owner-tree.ui
@@ -122,7 +122,7 @@
       <attribute name="temp" translatable="no">yes</attribute>
     </item>
     <item>
-      <attribute name="label" translatable="no">Vendor Listing</attribute>
+      <attribute name="label" translatable="yes">Vendor Listing</attribute>
       <attribute name="action">GncPluginPageOwnerTreeActions.OTVendorListingReportAction</attribute>
       <attribute name="tooltip" translatable="yes">Show vendor aging overview for all vendors</attribute>
       <attribute name="temp" translatable="no">yes</attribute>
@@ -131,7 +131,7 @@
 
   <menu id="ReportsPlaceholder1-e">
     <item>
-      <attribute name="label" translatable="no">Employee Report</attribute>
+      <attribute name="label" translatable="yes">Employee Report</attribute>
       <attribute name="action">GncPluginPageOwnerTreeActions.OTEmployeeReportAction</attribute>
       <attribute name="tooltip" translatable="yes">Show employee report</attribute>
       <attribute name="temp" translatable="no">yes</attribute>
diff --git a/gnucash/ui/gnc-plugin-page-register.ui b/gnucash/ui/gnc-plugin-page-register.ui
index d7ff0def88..07bd23c566 100644
--- a/gnucash/ui/gnc-plugin-page-register.ui
+++ b/gnucash/ui/gnc-plugin-page-register.ui
@@ -104,12 +104,12 @@
 
   <menu id="ViewPlaceholder3">
     <item>
-      <attribute name="label" translatable="no">_Sort By…</attribute>
+      <attribute name="label" translatable="yes">_Sort By…</attribute>
       <attribute name="action">GncPluginPageRegisterActions.ViewSortByAction</attribute>
       <attribute name="temp" translatable="no">yes</attribute>
     </item>
     <item>
-      <attribute name="label" translatable="no">_Filter By…</attribute>
+      <attribute name="label" translatable="yes">_Filter By…</attribute>
       <attribute name="action">GncPluginPageRegisterActions.ViewFilterByAction</attribute>
       <attribute name="temp" translatable="no">yes</attribute>
     </item>
diff --git a/gnucash/ui/gnc-plugin-page-report.ui b/gnucash/ui/gnc-plugin-page-report.ui
index 832766593f..62c10cc2fa 100644
--- a/gnucash/ui/gnc-plugin-page-report.ui
+++ b/gnucash/ui/gnc-plugin-page-report.ui
@@ -40,14 +40,14 @@
 
   <menu id="ReportsPlaceholder1">
     <item>
-      <attribute name="label" translatable="no">Save _Report Configuration</attribute>
+      <attribute name="label" translatable="yes">Save _Report Configuration</attribute>
       <attribute name="action">GncPluginPageReportActions.ReportSaveAction</attribute>
       <attribute name="accel"><Primary><Alt>s</attribute>
       <attribute name="tooltip" translatable="yes">Update the current report's saved configuration</attribute>
       <attribute name="temp" translatable="no">yes</attribute>
     </item>
     <item>
-      <attribute name="label" translatable="no">Save Report Configuration As…</attribute>
+      <attribute name="label" translatable="yes">Save Report Configuration As…</attribute>
       <attribute name="action">GncPluginPageReportActions.ReportSaveAsAction</attribute>
       <attribute name="accel"><Primary><Alt><Shift>s</attribute>
       <attribute name="tooltip" translatable="yes">Add the current report's configuration to the 'Reports->Saved Report Configurations' menu</attribute>



Summary of changes:
 gnucash/gnome-utils/dialog-commodity.c     | 6 ++++--
 gnucash/ui/gnc-embedded-register-window.ui | 2 +-
 gnucash/ui/gnc-plugin-page-account-tree.ui | 6 +++---
 gnucash/ui/gnc-plugin-page-invoice.ui      | 2 +-
 gnucash/ui/gnc-plugin-page-owner-tree.ui   | 4 ++--
 gnucash/ui/gnc-plugin-page-register.ui     | 4 ++--
 gnucash/ui/gnc-plugin-page-report.ui       | 4 ++--
 7 files changed, 15 insertions(+), 13 deletions(-)



More information about the gnucash-changes mailing list