gnucash stable: Bug 799262 - Failed import QIF investment

[Christopher Lam]

Updated	 via  https://github.com/Gnucash/gnucash/commit/b33b864c (commit)
	from  https://github.com/Gnucash/gnucash/commit/9f998892 (commit)



commit b33b864c2fa0ba72d1940465e7fa962dd36833c9
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Apr 2 08:22:20 2024 +0800

    Bug 799262 - Failed import QIF investment
    
    the qif-action check should apply to investment transactions only.

diff --git a/gnucash/import-export/qif-imp/qif-to-gnc.scm b/gnucash/import-export/qif-imp/qif-to-gnc.scm
index c67defab36..690fee02dd 100644
--- a/gnucash/import-export/qif-imp/qif-to-gnc.scm
+++ b/gnucash/import-export/qif-imp/qif-to-gnc.scm
@@ -596,13 +596,6 @@
       (else
         (apply xaccTransSetDate gnc-xtn (qif-xtn:date qif-xtn))))
 
-    (unless qif-action
-      (qif-import:log progress-dialog "qif-import:qif-xtn-to-gnc-xtn"
-                      (format #f (G_ "Missing QIF investment action for transaction dated ~a.")
-                              (qof-print-date (qif-date-to-time64 qif-date))))
-      (throw 'missing-action "qif-import:qif-xtn-to-gnc-xtn" "Missing investment action."
-             #f #f))
-
     ;; fixme: bug #105
     (if qif-payee
         (xaccTransSetDescription gnc-xtn qif-payee))
@@ -743,6 +736,13 @@
 
           (if (not num-shares) (set! num-shares (gnc-numeric-zero)))
 
+          (unless qif-action
+            (qif-import:log progress-dialog "qif-import:qif-xtn-to-gnc-xtn"
+                            (format #f (G_ "Missing QIF investment action for transaction dated ~a.")
+                                    (qof-print-date (qif-date-to-time64 qif-date))))
+            (throw 'missing-action "qif-import:qif-xtn-to-gnc-xtn" "Missing investment action."
+                   #f #f))
+
           ;; Determine the extended price of all shares without commission.
           (if xtn-amt
               ;; Adjust for commission (if any).



Summary of changes:
 gnucash/import-export/qif-imp/qif-to-gnc.scm | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)