gnucash stable: Multiple changes pushed

John Ralls jralls at code.gnucash.org
Mon Apr 22 21:05:25 EDT 2024


Updated	 via  https://github.com/Gnucash/gnucash/commit/9c18bc88 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d01aad68 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6696bf0a (commit)
	from  https://github.com/Gnucash/gnucash/commit/5dab612d (commit)



commit 9c18bc889c52daad5616b100e2924c46572bdabf
Author: John Ralls <jralls at ceridwen.us>
Date:   Mon Apr 22 18:05:02 2024 -0700

    Don't use Googletest internal API for unused decls.

diff --git a/libgnucash/engine/test/gtest-gnc-int128.cpp b/libgnucash/engine/test/gtest-gnc-int128.cpp
index 23c2b27053..4f28bdd262 100644
--- a/libgnucash/engine/test/gtest-gnc-int128.cpp
+++ b/libgnucash/engine/test/gtest-gnc-int128.cpp
@@ -192,33 +192,33 @@ TEST(GncInt128_functions, test_int_functions)
         });
 
     GncInt128 value2 (UINT64_C(0), uarg);
-    EXPECT_THROW (auto v GTEST_ATTRIBUTE_UNUSED_ = static_cast<int64_t>(value2), std::overflow_error);
+    EXPECT_THROW (auto v [[maybe_unused]] = static_cast<int64_t>(value2), std::overflow_error);
     EXPECT_EQ (uarg, static_cast<uint64_t>(value2));
 
     GncInt128 value3 (UINT64_C(0), uarg, GncInt128::neg);
-    EXPECT_THROW (auto v GTEST_ATTRIBUTE_UNUSED_ = static_cast<int64_t>(value3), std::underflow_error);
-    EXPECT_THROW (auto v GTEST_ATTRIBUTE_UNUSED_ = static_cast<uint64_t>(value3), std::underflow_error);
+    EXPECT_THROW (auto v [[maybe_unused]] = static_cast<int64_t>(value3), std::underflow_error);
+    EXPECT_THROW (auto v [[maybe_unused]] = static_cast<uint64_t>(value3), std::underflow_error);
 
     GncInt128 value4 (UINT64_C(0), uarg, GncInt128::overflow);
-    EXPECT_THROW (auto v GTEST_ATTRIBUTE_UNUSED_ = static_cast<int64_t>(value4), std::overflow_error);
-    EXPECT_THROW (auto v GTEST_ATTRIBUTE_UNUSED_ = static_cast<uint64_t>(value4), std::overflow_error);
+    EXPECT_THROW (auto v [[maybe_unused]] = static_cast<int64_t>(value4), std::overflow_error);
+    EXPECT_THROW (auto v [[maybe_unused]] = static_cast<uint64_t>(value4), std::overflow_error);
 
     GncInt128 value5 (UINT64_C(0), uarg, GncInt128::NaN);
-    EXPECT_THROW (auto v GTEST_ATTRIBUTE_UNUSED_ = static_cast<int64_t>(value5), std::overflow_error);
-    EXPECT_THROW (auto v GTEST_ATTRIBUTE_UNUSED_ = static_cast<uint64_t>(value5), std::overflow_error);
+    EXPECT_THROW (auto v [[maybe_unused]] = static_cast<int64_t>(value5), std::overflow_error);
+    EXPECT_THROW (auto v [[maybe_unused]] = static_cast<uint64_t>(value5), std::overflow_error);
 
     GncInt128 value6 (INT64_C(1), arg);
-    EXPECT_THROW (auto v GTEST_ATTRIBUTE_UNUSED_ = static_cast<int64_t>(value6), std::overflow_error);
+    EXPECT_THROW (auto v [[maybe_unused]] = static_cast<int64_t>(value6), std::overflow_error);
     EXPECT_EQ (arg + (UINT64_C(0x1) << 63), static_cast<uint64_t>(value6));
 
     GncInt128 value7 (INT64_C(-1), arg);
     EXPECT_EQ (-static_cast<int64_t>((UINT64_C(0x1) << 63) - arg),
                static_cast<int64_t>(value7));
-    EXPECT_THROW (auto v GTEST_ATTRIBUTE_UNUSED_ = static_cast<uint64_t>(value7), std::underflow_error);
+    EXPECT_THROW (auto v [[maybe_unused]] = static_cast<uint64_t>(value7), std::underflow_error);
 
     GncInt128 value8 (INT64_C(0), narg);
     EXPECT_EQ (narg, static_cast<int64_t>(value8));
-    EXPECT_THROW (auto v GTEST_ATTRIBUTE_UNUSED_ = static_cast<uint64_t>(value8), std::underflow_error);
+    EXPECT_THROW (auto v [[maybe_unused]] = static_cast<uint64_t>(value8), std::underflow_error);
 
     GncInt128 value9 (INT64_C(1), narg);
     EXPECT_EQ (static_cast<int64_t>((UINT64_C(0x1) << 63) + narg),
@@ -226,8 +226,8 @@ TEST(GncInt128_functions, test_int_functions)
     EXPECT_EQ ((UINT64_C(0x1) << 63) + narg, static_cast<uint64_t>(value9));
 
     GncInt128 value10 (INT64_C(-2), arg);
-    EXPECT_THROW (auto v GTEST_ATTRIBUTE_UNUSED_ = static_cast<int64_t>(value10), std::underflow_error);
-    EXPECT_THROW (auto v GTEST_ATTRIBUTE_UNUSED_ = static_cast<uint64_t>(value10),
+    EXPECT_THROW (auto v [[maybe_unused]] = static_cast<int64_t>(value10), std::underflow_error);
+    EXPECT_THROW (auto v [[maybe_unused]] = static_cast<uint64_t>(value10),
                   std::underflow_error);
 
 }

commit d01aad68fbba70feebff678958928744a5cce568
Author: Bruce P Schuck <bschuck at asgard-systems.com>
Date:   Sun Apr 7 17:36:23 2024 -0700

    Update gnc-commodity.cpp
    
    Fool.pm not working. Removed references to it from sources JSON structures.

diff --git a/libgnucash/engine/gnc-commodity.cpp b/libgnucash/engine/gnc-commodity.cpp
index b67c92e3b0..a1d35aeb33 100644
--- a/libgnucash/engine/gnc-commodity.cpp
+++ b/libgnucash/engine/gnc-commodity.cpp
@@ -202,7 +202,6 @@ static QuoteSourceVec single_quote_sources =
     { false, SOURCE_SINGLE, "India Mutual", "indiamutual" },
     { false, SOURCE_SINGLE, "Morningstar, GB", "morningstaruk" },
     { false, SOURCE_SINGLE, "Morningstar, JP", "morningstarjp" },
-    { false, SOURCE_SINGLE, "Motley Fool, US", "fool" },
     { false, SOURCE_SINGLE, "New Zealand stock eXchange, NZ", "nzx" },
     { false, SOURCE_SINGLE, "Paris Stock Exchange/Boursorama, FR", "bourso" },
     { false, SOURCE_SINGLE, "Romania", "romania" },
@@ -228,13 +227,13 @@ static QuoteSourceVec multiple_quote_sources =
     { false, SOURCE_MULTI, "Europe (asegr,.bsero, hex ...)", "europe" },
     { false, SOURCE_MULTI, "India Mutual (AMFI, ...)", "indiamutual" },
     { false, SOURCE_MULTI, "France (bourso, ĺerevenu, ...)", "france" },
-    { false, SOURCE_MULTI, "Nasdaq (alphavantage, fool, ...)", "nasdaq" },
-    { false, SOURCE_MULTI, "NYSE (alphavantage, fool, ...)", "nyse" },
+    { false, SOURCE_MULTI, "Nasdaq (alphavantage, yahoo_json, ...)", "nasdaq" },
+    { false, SOURCE_MULTI, "NYSE (alphavantage, yahoo_json, ...)", "nyse" },
     { false, SOURCE_MULTI, "South Africa (Sharenet, ...)", "za" },
     { false, SOURCE_MULTI, "Romania (BSE-RO, ...)", "romania" },
     { false, SOURCE_MULTI, "T. Rowe Price", "troweprice" },
     { false, SOURCE_MULTI, "U.K. Funds (citywire, FTfunds, MStar, tnetuk, ...)", "ukfunds" },
-    { false, SOURCE_MULTI, "USA (Alphavantage, Fool, ...)", "usa" },
+    { false, SOURCE_MULTI, "USA (alphavantage, yahoo_json, ...)", "usa" },
 };
 
 static QuoteSourceVec new_quote_sources;

commit 6696bf0a417f795aa97a3f52311491a3d671423a
Author: Bruce Schuck <bschuck at asgard-systems.com>
Date:   Sat Apr 6 18:23:35 2024 -0700

    Updated QuoteSourceVec to match F::Q v1.59

diff --git a/libgnucash/engine/gnc-commodity.cpp b/libgnucash/engine/gnc-commodity.cpp
index b0b2a6fd3a..b67c92e3b0 100644
--- a/libgnucash/engine/gnc-commodity.cpp
+++ b/libgnucash/engine/gnc-commodity.cpp
@@ -189,65 +189,34 @@ static QuoteSourceVec single_quote_sources =
 {
     { false, SOURCE_SINGLE, "Alphavantage, US", "alphavantage" },
     { false, SOURCE_SINGLE, "Amsterdam Euronext eXchange, NL", "aex" },
-    { false, SOURCE_SINGLE, "American International Assurance, HK", "aiahk" },
     { false, SOURCE_SINGLE, "Association of Mutual Funds in India", "amfiindia" },
-    { false, SOURCE_SINGLE, "Athens Stock Exchange, GR", "asegr" },
     { false, SOURCE_SINGLE, "Australian Stock Exchange, AU", "asx" },
-    { false, SOURCE_SINGLE, "BAMOSZ funds, HU", "bamosz" },
-    { false, SOURCE_SINGLE, "BMO NesbittBurns, CA", "bmonesbittburns" },
-    { false, SOURCE_SINGLE, "Bucharest Stock Exchange, RO", "bsero" },
-    { false, SOURCE_SINGLE, "Budapest Stock Exchange (BET), ex-BUX, HU", "bse" },
     { false, SOURCE_SINGLE, "Canada Mutual", "canadamutual" },
-    { false, SOURCE_SINGLE, "Citywire Funds, GB", "citywire" },
-    { false, SOURCE_SINGLE, "Colombo Stock Exchange, LK", "cse" },
-    { false, SOURCE_SINGLE, "Cominvest, ex-Adig, DE", "cominvest" },
     { false, SOURCE_SINGLE, "Deka Investments, DE", "deka" },
     { false, SOURCE_SINGLE, "Dutch", "dutch" },
     { false, SOURCE_SINGLE, "DWS, DE", "dwsfunds" },
-    { false, SOURCE_SINGLE, "Equinox Unit Trusts, ZA", "za_unittrusts" },
-    { false, SOURCE_SINGLE, "Fidelity Direct", "fidelity_direct" },
-    { false, SOURCE_SINGLE, "Fidelity Fixed", "fidelityfixed" },
-    { false, SOURCE_SINGLE, "Finance Canada", "financecanada" },
     { false, SOURCE_SINGLE, "Financial Times Funds service, GB", "ftfunds" },
     { false, SOURCE_SINGLE, "Finanzpartner, DE", "finanzpartner" },
-    { false, SOURCE_SINGLE, "First Trust Portfolios, US", "ftportfolios" },
-    { false, SOURCE_SINGLE, "Fund Library, CA", "fundlibrary" },
     { false, SOURCE_SINGLE, "GoldMoney spot rates, JE", "goldmoney" },
-    { false, SOURCE_SINGLE, "Greece", "greece" },
-    { false, SOURCE_SINGLE, "Helsinki stock eXchange, FI", "hex" },
-    { false, SOURCE_SINGLE, "Hungary", "hu" },
+    { false, SOURCE_SINGLE, "Google Web, US Stocks", "googleweb" },
     { false, SOURCE_SINGLE, "India Mutual", "indiamutual" },
-    { false, SOURCE_SINGLE, "Man Investments, AU", "maninv" },
-    { false, SOURCE_SINGLE, "Morningstar, GB", "mstaruk" },
+    { false, SOURCE_SINGLE, "Morningstar, GB", "morningstaruk" },
     { false, SOURCE_SINGLE, "Morningstar, JP", "morningstarjp" },
-    { false, SOURCE_SINGLE, "Morningstar, SE", "morningstar" },
     { false, SOURCE_SINGLE, "Motley Fool, US", "fool" },
     { false, SOURCE_SINGLE, "New Zealand stock eXchange, NZ", "nzx" },
     { false, SOURCE_SINGLE, "Paris Stock Exchange/Boursorama, FR", "bourso" },
-    { false, SOURCE_SINGLE, "Paris Stock Exchange/LeRevenu, FR", "lerevenu" },
-    { false, SOURCE_SINGLE, "Platinum Asset Management, AU", "platinum" },
     { false, SOURCE_SINGLE, "Romania", "romania" },
-    { false, SOURCE_SINGLE, "SIX Swiss Exchange funds, CH", "sixfunds" },
-    { false, SOURCE_SINGLE, "SIX Swiss Exchange shares, CH", "sixshares" },
+    { false, SOURCE_SINGLE, "SIX Swiss Exchange shares, CH", "six" },
     { false, SOURCE_SINGLE, "Skandinaviska Enskilda Banken, SE", "seb_funds" },
     { false, SOURCE_SINGLE, "Sharenet, ZA", "za" },
-    { false, SOURCE_SINGLE, "StockHouse Canada", "stockhousecanada_fund" },
-    { false, SOURCE_SINGLE, "TD Waterhouse Funds, CA", "tdwaterhouse" },
-    { false, SOURCE_SINGLE, "TD Efunds, CA", "tdefunds" },
     { false, SOURCE_SINGLE, "TIAA-CREF, US", "tiaacref" },
     { false, SOURCE_SINGLE, "Toronto Stock eXchange, CA", "tsx" },
     { false, SOURCE_SINGLE, "T. Rowe Price", "troweprice" },
     { false, SOURCE_SINGLE, "T. Rowe Price, US", "troweprice_direct" },
-    { false, SOURCE_SINGLE, "Trustnet via tnetuk.pm, GB", "tnetuk" },
-    { false, SOURCE_SINGLE, "Trustnet via trustnet.pm, GB", "trustnet" },
-    { false, SOURCE_SINGLE, "U.K. Unit Trusts", "uk_unit_trusts" },
     { false, SOURCE_SINGLE, "Union Investment, DE", "unionfunds" },
-    { false, SOURCE_SINGLE, "US Treasury Bonds", "usfedbonds" },
     { false, SOURCE_SINGLE, "US Govt. Thrift Savings Plan", "tsp" },
-    { false, SOURCE_SINGLE, "Vanguard", "vanguard" }, /* Method of Alphavantage */
-    { false, SOURCE_SINGLE, "VWD, DE (unmaintained)", "vwd" },
     { false, SOURCE_SINGLE, "Yahoo as JSON", "yahoo_json" },
-    { false, SOURCE_SINGLE, "Yahoo as YQL", "yahoo_yql" },
+    { false, SOURCE_SINGLE, "Yahoo Web", "yahooweb" },
 };
 
 static QuoteSourceVec multiple_quote_sources =
@@ -257,21 +226,14 @@ static QuoteSourceVec multiple_quote_sources =
     { false, SOURCE_MULTI, "Canada Mutual (Fund Library, StockHouse, ...)", "canadamutual" },
     { false, SOURCE_MULTI, "Dutch (AEX, ...)", "dutch" },
     { false, SOURCE_MULTI, "Europe (asegr,.bsero, hex ...)", "europe" },
-    { false, SOURCE_MULTI, "Greece (ASE, ...)", "greece" },
-    { false, SOURCE_MULTI, "Hungary (Bamosz, BET, ...)", "hu" },
     { false, SOURCE_MULTI, "India Mutual (AMFI, ...)", "indiamutual" },
-    { false, SOURCE_MULTI, "Fidelity (Fidelity, ...)", "fidelity" },
-    { false, SOURCE_MULTI, "Finland (HEX, ...)", "finland" },
-    { false, SOURCE_MULTI, "First Trust (First Trust, ...)", "ftportfolios" },
     { false, SOURCE_MULTI, "France (bourso, ĺerevenu, ...)", "france" },
     { false, SOURCE_MULTI, "Nasdaq (alphavantage, fool, ...)", "nasdaq" },
-    { false, SOURCE_MULTI, "New Zealand (NZX, ...)", "nz" },
     { false, SOURCE_MULTI, "NYSE (alphavantage, fool, ...)", "nyse" },
     { false, SOURCE_MULTI, "South Africa (Sharenet, ...)", "za" },
     { false, SOURCE_MULTI, "Romania (BSE-RO, ...)", "romania" },
     { false, SOURCE_MULTI, "T. Rowe Price", "troweprice" },
     { false, SOURCE_MULTI, "U.K. Funds (citywire, FTfunds, MStar, tnetuk, ...)", "ukfunds" },
-    { false, SOURCE_MULTI, "U.K. Unit Trusts (trustnet, ...)", "uk_unit_trusts" },
     { false, SOURCE_MULTI, "USA (Alphavantage, Fool, ...)", "usa" },
 };
 



Summary of changes:
 libgnucash/engine/gnc-commodity.cpp         | 53 ++++-------------------------
 libgnucash/engine/test/gtest-gnc-int128.cpp | 24 ++++++-------
 2 files changed, 19 insertions(+), 58 deletions(-)



More information about the gnucash-changes mailing list