gnucash stable: Better fit for some report option widgets in options dialog.

John Ralls jralls at code.gnucash.org
Thu Aug 1 19:23:25 EDT 2024


Updated	 via  https://github.com/Gnucash/gnucash/commit/a626e944 (commit)
	from  https://github.com/Gnucash/gnucash/commit/6b873889 (commit)



commit a626e944a3ac1900197bc4f8bd3db04f0edd224f
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu Aug 1 16:22:19 2024 -0700

    Better fit for some report option widgets in options dialog.
    
    Replaces https://github.com/Gnucash/gnucash/pull/1975

diff --git a/gnucash/gnome-utils/dialog-options.cpp b/gnucash/gnome-utils/dialog-options.cpp
index 16e51920da..6a56a3c0c0 100644
--- a/gnucash/gnome-utils/dialog-options.cpp
+++ b/gnucash/gnome-utils/dialog-options.cpp
@@ -217,7 +217,8 @@ create_options_box(GtkBox* content_box)
     gtk_grid_set_column_homogeneous (GTK_GRID(options_box), FALSE);
     gtk_grid_set_row_spacing (GTK_GRID(options_box), 6);
     gtk_grid_set_column_spacing (GTK_GRID(options_box), 6);
-
+    git_widget_set_halign (GTK_WIDGET(options_box), GTK_ALIGN_START);
+    
     gtk_container_set_border_width(GTK_CONTAINER(options_box), 0);
     gtk_container_add (GTK_CONTAINER(options_scrolled_win),
                        GTK_WIDGET(options_box));
diff --git a/gnucash/gnome-utils/gnc-option-gtk-ui.cpp b/gnucash/gnome-utils/gnc-option-gtk-ui.cpp
index 0ae6c285f1..898dda1f28 100644
--- a/gnucash/gnome-utils/gnc-option-gtk-ui.cpp
+++ b/gnucash/gnome-utils/gnc-option-gtk-ui.cpp
@@ -20,6 +20,7 @@
  * Boston, MA  02110-1301,  USA       gnu at gnu.org                   *
 \********************************************************************/
 
+#include <__nullptr>
 #include <gnc-option.hpp>
 #include <gnc-option-impl.hpp>
 #include "gnc-option-gtk-ui.hpp"
@@ -1104,6 +1105,10 @@ create_option_widget<GncOptionUIType::ACCOUNT_SEL> (GncOption& option,
     g_signal_connect(widget, "account_sel_changed",
                      G_CALLBACK(gnc_option_changed_widget_cb), &option);
     wrap_widget(option, widget, page_box, row);
+    // wrap_widget sets the parent so this comes after.
+    gtk_container_child_set(GTK_CONTAINER(gtk_widget_get_parent(widget)),
+                            widget, "fill", TRUE, "expand", TRUE,
+                            nullptr);
 }
 
 static void



Summary of changes:
 gnucash/gnome-utils/dialog-options.cpp    | 3 ++-
 gnucash/gnome-utils/gnc-option-gtk-ui.cpp | 5 +++++
 2 files changed, 7 insertions(+), 1 deletion(-)



More information about the gnucash-changes mailing list