gnucash stable: [commodity-utilities.scm] gnc:get-commoditylist-totalavg-prices uses premade function

Christopher Lam clam at code.gnucash.org
Mon Jan 15 07:55:52 EST 2024


Updated	 via  https://github.com/Gnucash/gnucash/commit/706030f7 (commit)
	from  https://github.com/Gnucash/gnucash/commit/1a5247c1 (commit)



commit 706030f7b0351c3aae83c45a5494fe2e634e589d
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sat Jan 13 21:59:20 2024 +0800

    [commodity-utilities.scm] gnc:get-commoditylist-totalavg-prices uses premade function
    
    gnc:get-match-commodity-splits-sorted does the exact same job.

diff --git a/gnucash/report/commodity-utilities.scm b/gnucash/report/commodity-utilities.scm
index 44173e6cb1..a91b8ba9e5 100644
--- a/gnucash/report/commodity-utilities.scm
+++ b/gnucash/report/commodity-utilities.scm
@@ -218,17 +218,9 @@
 (define (gnc:get-commoditylist-totalavg-prices
          commodity-list report-currency end-date
          start-percent delta-percent)
-  (define (interesting-split? s)
-    (not (gnc-commodity-equiv
-          (xaccTransGetCurrency (xaccSplitGetParent s))
-          (xaccAccountGetCommodity (xaccSplitGetAccount s)))))
-  (define (date<? a b)
-    (< (xaccTransGetDate (xaccSplitGetParent a))
-       (xaccTransGetDate (xaccSplitGetParent b))))
   (let* ((currency-accounts
           (gnc-account-get-descendants-sorted (gnc-get-current-root-account)))
-         (all-splits (get-all-splits currency-accounts end-date))
-         (interesting-splits (sort (filter interesting-split? all-splits) date<?))
+         (interesting-splits (gnc:get-match-commodity-splits-sorted currency-accounts end-date #f))
          (commodity-list (delete-duplicates commodity-list))
          (work-to-do (length commodity-list)))
     (map



Summary of changes:
 gnucash/report/commodity-utilities.scm | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)



More information about the gnucash-changes mailing list