gnucash stable: [utest-Account.cpp] use qof_instance kvp API for const char*
Christopher Lam
clam at code.gnucash.org
Wed Jul 2 11:47:04 EDT 2025
Updated via https://github.com/Gnucash/gnucash/commit/754a1eb4 (commit)
from https://github.com/Gnucash/gnucash/commit/e48c2931 (commit)
commit 754a1eb42fac9f37d94ecb29252473b89fd83e13
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Wed Jun 25 09:32:38 2025 +0800
[utest-Account.cpp] use qof_instance kvp API for const char*
diff --git a/libgnucash/engine/test/utest-Account.cpp b/libgnucash/engine/test/utest-Account.cpp
index 7f8585c17d..2415914168 100644
--- a/libgnucash/engine/test/utest-Account.cpp
+++ b/libgnucash/engine/test/utest-Account.cpp
@@ -1328,17 +1328,8 @@ set_kvp_string_path (Account *acc, std::vector<std::string> const & path,
const char *value)
{
xaccAccountBeginEdit(acc);
- if (value)
- {
- GValue v = G_VALUE_INIT;
- g_value_init (&v, G_TYPE_STRING);
- g_value_set_string (&v, value);
- qof_instance_set_path_kvp (QOF_INSTANCE (acc), &v, path);
- g_value_unset (&v);
- }
- else
- qof_instance_set_path_kvp (QOF_INSTANCE (acc), NULL, path);
-
+ auto val = value ? std::make_optional<const char*>(g_strdup(value)) : std::nullopt;
+ qof_instance_set_path_kvp<const char*> (QOF_INSTANCE (acc), val, path);
xaccAccountCommitEdit(acc);
}
Summary of changes:
libgnucash/engine/test/utest-Account.cpp | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
More information about the gnucash-changes
mailing list