gnucash stable: Multiple changes pushed

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/36ff6520 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/2db6d51a (commit)
	from  https://github.com/Gnucash/gnucash/commit/3d4f19f8 (commit)



commit 36ff652012dae784319e3c720ad129a9329e8c22
Merge: 3d4f19f830 2db6d51a2a
Author: John Ralls <jralls at ceridwen.us>
Date:   Mon Mar 16 19:23:08 2026 -0700

    Merge Sherlock's 'completion-cell-leak' into stable.


commit 2db6d51a2ae394d778eec968f0ed0df6771c9582
Author: Sherlock <119709043+agwekixj at users.noreply.github.com>
Date:   Sat Mar 14 23:09:43 2026 -0700

    Fix completion cell gui leak
    
    The gui_realize test in gnc_completion_cell_gui_destroy() is corrected.  The item_store allocation is moved to gnc_completion_cell_gui_realize() and the item_store is released in gnc_completion_cell_gui_destroy().  The patch also modifies item_store_clear() and populate_list_store() for clarity.

diff --git a/gnucash/register/register-gnome/completioncell-gnome.c b/gnucash/register/register-gnome/completioncell-gnome.c
index 9e636e924f..40d399d4e0 100644
--- a/gnucash/register/register-gnome/completioncell-gnome.c
+++ b/gnucash/register/register-gnome/completioncell-gnome.c
@@ -119,8 +119,8 @@ gnc_completion_cell_init (CompletionCell* cell)
     box->sheet = NULL;
     box->item_edit = NULL;
     box->item_list = NULL;
-    box->item_store = gtk_list_store_new (4, G_TYPE_STRING, G_TYPE_STRING,
-                                             G_TYPE_INT, G_TYPE_INT);
+    box->item_store = NULL;
+
     box->signals_connected = FALSE;
     box->list_popped = FALSE;
     box->autosize = FALSE;
@@ -326,14 +326,22 @@ gnc_completion_cell_gui_destroy (BasicCell* bcell)
 {
     CompletionCell* cell = (CompletionCell*) bcell;
 
-    if (cell->cell.gui_realize)
+    if (!cell->cell.gui_realize)
     {
         PopBox* box = bcell->gui_private;
-        if (box && box->item_list)
+        if (box)
         {
-            completion_disconnect_signals (cell);
-            g_object_unref (box->item_list);
-            box->item_list = NULL;
+            if (box->item_list)
+            {
+                completion_disconnect_signals (cell);
+                g_object_unref (box->item_list);
+                box->item_list = NULL;
+            }
+            if (box->item_store)
+            {
+                g_object_unref (box->item_store);
+                box->item_store = NULL;
+            }
         }
         /* allow the widget to be shown again */
         cell->cell.gui_realize = gnc_completion_cell_gui_realize;
@@ -415,7 +423,7 @@ item_store_clear (CompletionCell* cell)
     PopBox* box = cell->cell.gui_private;
 
     // disconnect list store from tree view
-    GtkListStore *store = gnc_item_list_disconnect_store (box->item_list);
+    gnc_item_list_disconnect_store (box->item_list);
 
     block_list_signals (cell);
 
@@ -430,7 +438,7 @@ item_store_clear (CompletionCell* cell)
     unblock_list_signals (cell);
 
     // reconect list store to tree view
-    gnc_item_list_connect_store (box->item_list, store);
+    gnc_item_list_connect_store (box->item_list, box->item_store);
 
     hide_popup (box);
 }
@@ -635,7 +643,7 @@ populate_list_store (CompletionCell* cell, gchar* str)
     box->newval_len = g_utf8_strlen (str, -1);
 
     // disconnect list store from tree view
-    box->item_store = gnc_item_list_disconnect_store (box->item_list);
+    gnc_item_list_disconnect_store (box->item_list);
 
     block_list_signals (cell);
 
@@ -820,6 +828,8 @@ gnc_completion_cell_gui_realize (BasicCell* bcell, gpointer data)
     /* initialize gui-specific, private data */
     box->sheet = sheet;
     box->item_edit = item_edit;
+    box->item_store = gtk_list_store_new (4, G_TYPE_STRING, G_TYPE_STRING,
+                                             G_TYPE_INT, G_TYPE_INT);
     box->item_list = GNC_ITEM_LIST(gnc_item_list_new (box->item_store));
 
     block_list_signals (cell);



Summary of changes:
 .../register/register-gnome/completioncell-gnome.c | 30 ++++++++++++++--------
 1 file changed, 20 insertions(+), 10 deletions(-)