gnucash stable: Multiple changes pushed
John Ralls
jralls at code.gnucash.org
Sat Mar 21 16:38:41 EDT 2026
Updated via https://github.com/Gnucash/gnucash/commit/74b9879c (commit)
via https://github.com/Gnucash/gnucash/commit/e81398d8 (commit)
via https://github.com/Gnucash/gnucash/commit/b78e73a9 (commit)
via https://github.com/Gnucash/gnucash/commit/dbeb9789 (commit)
via https://github.com/Gnucash/gnucash/commit/8c344b04 (commit)
via https://github.com/Gnucash/gnucash/commit/8449b791 (commit)
from https://github.com/Gnucash/gnucash/commit/f8a8a077 (commit)
commit 74b9879c7575727bfc4886838d72a311110bdb7c
Merge: e81398d8e7 8449b791c2
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Mar 21 13:35:29 2026 -0700
Merge Sherlock's "TreeView GUI Leak" into stable.
commit e81398d8e781145c865e7efb81f56476a9564eb9
Merge: b78e73a9ab 8c344b048e
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Mar 21 13:34:06 2026 -0700
Merge Sherlock's "Plugin Page Register GUI Leak" into stable.
commit b78e73a9ab3ca5d48636af2ac11988698c43ba2f
Merge: f8a8a07774 dbeb97891e
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Mar 21 13:31:25 2026 -0700
Merge Sherlock's 'Plugin Page Report Gui Leak' into stable.
commit dbeb97891e1818a51ff9ac75a2a94f3cf35cefc9
Author: Sherlock <119709043+agwekixj at users.noreply.github.com>
Date: Fri Mar 20 14:47:25 2026 -0700
Fix plugin page report gui leak
Added g_object_unref() of priv->container to gnc_plugin_page_report_destroy().
diff --git a/gnucash/gnome/gnc-plugin-page-report.cpp b/gnucash/gnome/gnc-plugin-page-report.cpp
index 00dcea0eae..7278fb0476 100644
--- a/gnucash/gnome/gnc-plugin-page-report.cpp
+++ b/gnucash/gnome/gnc-plugin-page-report.cpp
@@ -1188,9 +1188,10 @@ gnc_plugin_page_report_destroy(GncPluginPageReportPrivate * priv)
}
gnc_html_destroy(priv->html);
+ priv->html = nullptr;
+ g_object_unref(priv->container);
priv->container = nullptr;
- priv->html = nullptr;
if (priv->cur_report != SCM_BOOL_F)
scm_gc_unprotect_object(priv->cur_report);
commit 8c344b048e3859c8370bbec866c05e6b7a1e9d66
Author: Sherlock <119709043+agwekixj at users.noreply.github.com>
Date: Fri Mar 20 14:42:43 2026 -0700
fix plugin page register gui leak
Added g_object_unref() of priv->widget to gnc_plugin_page_register_destroy_widget(). Also, removed the gtk_widget_destroy() of priv->psr as priv->psr will be handled by the g_object_unref () of priv->widget.
diff --git a/gnucash/gnome/gnc-plugin-page-register.cpp b/gnucash/gnome/gnc-plugin-page-register.cpp
index 58660e6b0c..6462bcc564 100644
--- a/gnucash/gnome/gnc-plugin-page-register.cpp
+++ b/gnucash/gnome/gnc-plugin-page-register.cpp
@@ -1506,11 +1506,12 @@ gnc_plugin_page_register_destroy_widget (GncPluginPage* plugin_page)
gtk_widget_hide (priv->widget);
- if (GTK_IS_WIDGET(priv->gsr))
- gtk_widget_destroy(GTK_WIDGET(priv->gsr));
-
gnc_ledger_display_close (priv->ledger);
priv->ledger = NULL;
+
+ g_object_unref(priv->widget);
+ priv->widget = NULL;
+
LEAVE (" ");
}
commit 8449b791c2ad1a4c28364d8f11f93400a7727dde
Author: Sherlock <119709043+agwekixj at users.noreply.github.com>
Date: Fri Mar 20 14:32:03 2026 -0700
Fix tree view gui leak
Added g_object_unref() of priv->column_menu_icon_box to gnc_tree_view_finalize().
diff --git a/gnucash/gnome-utils/gnc-tree-view.c b/gnucash/gnome-utils/gnc-tree-view.c
index 95e206c9fe..6f7005d831 100644
--- a/gnucash/gnome-utils/gnc-tree-view.c
+++ b/gnucash/gnome-utils/gnc-tree-view.c
@@ -325,7 +325,7 @@ gnc_tree_view_init (GncTreeView *view)
* @param obj The new object instance created by the object
* system.
*/
- static void
+static void
gnc_tree_view_constructed (GObject *obj)
{
gnc_gobject_tracking_remember(obj);
@@ -346,10 +346,17 @@ gnc_tree_view_constructed (GObject *obj)
static void
gnc_tree_view_finalize (GObject *object)
{
+ GncTreeView *view;
+ GncTreeViewPrivate *priv;
+
ENTER("view %p", object);
g_return_if_fail (object != NULL);
g_return_if_fail (GNC_IS_TREE_VIEW(object));
+ view = GNC_TREE_VIEW(object);
+ priv = GNC_TREE_VIEW_GET_PRIVATE(view);
+ g_object_unref(priv->column_menu_icon_box);
+
gnc_gobject_tracking_forget (object);
G_OBJECT_CLASS(gnc_tree_view_parent_class)->finalize (object);
Summary of changes:
gnucash/gnome-utils/gnc-tree-view.c | 9 ++++++++-
gnucash/gnome/gnc-plugin-page-register.cpp | 7 ++++---
gnucash/gnome/gnc-plugin-page-report.cpp | 3 ++-
3 files changed, 14 insertions(+), 5 deletions(-)
More information about the gnucash-changes
mailing list