Tax report bug

Richard -Gilligan- Uschold uschold@cs.ucf.edu
Wed, 22 Nov 2000 16:53:21 +0000


--------------4BFD19D48C113A47A3F63D16
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Robert Graham Merkel wrote:

> Richard -Gilligan- Uschold writes:
>
>  > > gnucash: latest CVS
>  > > guile: 1.3.4
>  > > g-wrap: 0.9.12
>  > >
>  > >  Herbert.
>  > > --
>  > > Herbert Thoma
>  > > FhG-IIS A, Studio Department
>  > > Am Weichselgarten3, 91058 Erlangen, Germany
>  > > Phone: +49-9131-776-323
>  > > Fax:   +49-9131-776-399
>  > > email: tma@iis.fhg.de
>  > > www: http://www.iis.fhg.de/
>  > >
>  > > _______________________________________________
>  > > gnucash-devel mailing list
>  > > gnucash-devel@lists.gnumatic.com
>  > > http://www.gnumatic.com/cgi-bin/mailman/listinfo/gnucash-devel
>  >
>  > I see a possible problem, but, as I don't yet have the latest compiled, (missing dependencies) I can't check it out.
>  > The problem does not seem to exist on 1.5.2 or earlier 1.4.x versions.  Could you add the line below marked with the
>  > "+" between existing lines 233 and 234, in file /usr/share/gnucash/scm/report/tax.scm, and let me know if it fixes the
>  > problem? (don't put in the "+"!)
>  >
>  >    (let* ((notes (gnc:account-get-notes a))
>  > +         (notes (if notes notes ""))
>  >           (key-start (string-search notes key 0))
>
> Richard, I haven't confirmed it, but I think the problem is that the
> handling of null const-strings has changed in the latest g-wrap.
>
> I think a NULL const string on the C side is converted to scheme #f.
>
> ------------------------------------------------------------
> Robert Merkel                              rgmerk@mira.net
>
> "We are excited and optimistic about its usage going
> forward and, yes, we can teach penguins the military
> close-order drill", Mark Norton, US Department of Defense.
> ------------------------------------------------------------

I uninstalled g-wrap 0.9.5 and installed 0.9.12.  gnucash-1.4.7, 1.4.8, and 1.5.2 all worked OK.  I then recompiled 1.5.2
and it still worked.  Perhaps the problem is in 1.5.3?  In any event, the above patch should fix the bug, no matter where it
is.

--

Gilligan            |                    __o           .oooO
                   /|                  _ \<,_          (   )
                  /p|\                (_)/ (_)          \ (   Oooo.
                 /  | \             ------------         \_)  (   )
                ========                                       ) /
                 ========       gilligan@mpinet.net           (_/
             ~~~~~~~~~~~~~~~~   uschold@cs.ucf.edu



--------------4BFD19D48C113A47A3F63D16
Content-Type: text/html; charset=us-ascii
Content-Transfer-Encoding: 7bit

<!doctype html public "-//w3c//dtd html 4.0 transitional//en">
Robert Graham Merkel wrote:
Richard -Gilligan- Uschold writes:

 > > gnucash: latest CVS
 > > guile: 1.3.4
 > > g-wrap: 0.9.12
 > >
 > >  Herbert.
 > > --
 > > Herbert Thoma
 > > FhG-IIS A, Studio Department
 > > Am Weichselgarten3, 91058 Erlangen, Germany
 > > Phone: +49-9131-776-323
 > > Fax:   +49-9131-776-399
 > > email: tma@iis.fhg.de
 > > www: http://www.iis.fhg.de/
 > >
 > > _______________________________________________
 > > gnucash-devel mailing list
 > > gnucash-devel@lists.gnumatic.com
 > > http://www.gnumatic.com/cgi-bin/mailman/listinfo/gnucash-devel
 >
 > I see a possible problem, but, as I don't yet have the latest compiled, (missing dependencies) I can't check it out.
 > The problem does not seem to exist on 1.5.2 or earlier 1.4.x versions.  Could you add the line below marked with the
 > "+" between existing lines 233 and 234, in file /usr/share/gnucash/scm/report/tax.scm, and let me know if it fixes the
 > problem? (don't put in the "+"!)
 >
 >    (let* ((notes (gnc:account-get-notes a))
 > +         (notes (if notes notes ""))
 >           (key-start (string-search notes key 0))

Richard, I haven't confirmed it, but I think the problem is that the
handling of null const-strings has changed in the latest g-wrap.

I think a NULL const string on the C side is converted to scheme #f.

------------------------------------------------------------
Robert Merkel                              rgmerk@mira.net

"We are excited and optimistic about its usage going
forward and, yes, we can teach penguins the military
close-order drill", Mark Norton, US Department of Defense.
------------------------------------------------------------

I uninstalled g-wrap 0.9.5 and installed 0.9.12.  gnucash-1.4.7, 1.4.8, and 1.5.2 all worked OK.  I then recompiled 1.5.2 and it still worked.  Perhaps the problem is in 1.5.3?  In any event, the above patch should fix the bug, no matter where it is.
-- 

Gilligan            |                    __o           .oooO
                   /|                  _ \<,_          (   )
                  /p|\                (_)/ (_)          \ (   Oooo.
                 /  | \             ------------         \_)  (   )
                ========                                       ) /
                 ========       gilligan@mpinet.net           (_/
             ~~~~~~~~~~~~~~~~   uschold@cs.ucf.edu
  --------------4BFD19D48C113A47A3F63D16--