Renaming subroutines

Conrad Canterford conrad@mail.watersprite.com.au
Thu, 18 Jan 2001 23:09:22 +1100


I'm wondering what the policy is with renaming subroutines.

My most recent change moved stuff from the status bar to a new summary
bar on the main window. However, the routine that refreshes this stuff
is still called "gnc_ui_refresh_statusbar".
For consistency and understandability, the current refresh subroutine
should probably become "gnc_ui_refresh_summarybar" (since all its
functionality now deals with the summary bar, not the status bar). As
far as I'm aware, this subroutine shouldn't be called anywhere outside
of window-main.c, so it should be safe to do so. Should I do this?

If I do this, should I leave an empty "gnc_ui_refresh_statusbar", since
the status bar still exists and may be used for something refreshable in
the future?

This is really trivial stuff, I realise. I'd have dealt with it in the
original patch, except that it was hastily constructed and sent patch
before my machine died (thanks Dave!).

Conrad.
-- 
Conrad Canterford (conrad@mail.watersprite.com.au)
Water Sprite Pty Ltd   | info@mail.watersprite.com.au
 GPO Box 355,          | Incorporating:
 Canberra, ACT, 2601   |   Australian Tour and Event Management (ATEM)
 Australia.            |   Ticketing Services Division
Phone: 0419 122 553    |   Catering Services Division