Bug: Transaction is Committed instead of Rollback'ed

[Derek Atkins]

Dave Peticolas <dave@krondo.com> writes:

> Where is xaccTransRollback being called in that trace?

Here is the call trace:

#0  xaccTransCommitEdit (trans=0x82931c0) at Transaction.c:1363
#1  0x806b497 in xaccSRSaveRegEntry (reg=0x828e2b8, do_commit=1)
    at SplitLedger.c:2841
#2  0x8069410 in LedgerMoveCursor (table=0x8292aa8, p_new_virt_loc=0xbfffeae0)
    at SplitLedger.c:984
#3  0x80bc9ed in gnc_table_move_cursor_internal (table=0x8292aa8, 
    new_virt_loc={vcell_loc = {virt_row = 8, virt_col = 0}, 
      phys_row_offset = 0, phys_col_offset = 0}, do_move_gui=1)
    at table-allgui.c:530
#4  0x80bcce6 in gnc_table_move_cursor_gui (table=0x8292aa8, new_virt_loc={
      vcell_loc = {virt_row = 8, virt_col = 0}, phys_row_offset = 0, 
      phys_col_offset = 0}) at table-allgui.c:665
#5  0x80bcd72 in gnc_table_verify_cursor_position (table=0x8292aa8, virt_loc={
      vcell_loc = {virt_row = 8, virt_col = 0}, phys_row_offset = 0, 
      phys_col_offset = 0}) at table-allgui.c:695
#6  0x80bceec in gnc_table_wrap_verify_cursor_position (table=0x8292aa8, 
    virt_loc={vcell_loc = {virt_row = 8, virt_col = 0}, phys_row_offset = 0, 
      phys_col_offset = 0}) at table-allgui.c:764
#7  0x80c47a0 in gnucash_sheet_cursor_move (sheet=0x82b6d30, virt_loc={
      vcell_loc = {virt_row = 8, virt_col = 0}, phys_row_offset = 0, 
      phys_col_offset = 0}) at gnucash-sheet.c:275
#8  0x80c6edb in gnucash_sheet_key_press_event (widget=0x82b6d30, 
    event=0x8243b10) at gnucash-sheet.c:1630

> Anyway, I guess it's a good idea to do just for safety's
> sake, but looking throught xaccTransRollback, I can't
> find anything that would call xaccTransCommitEdit.

> dave

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord@MIT.EDU                        PGP key available