HBCI-abort

Christian Stimming stimming@tuhh.de
Wed, 11 Dec 2002 21:38:11 +0100


-----BEGIN PGP SIGNED MESSAGE-----

Benoit,

On Mittwoch, 11. Dezember 2002 11:18, Eildert Groeneveld wrote:
> 2. get transaction, no pw required., the importer window comes up (I assume
>     that I got the transactions), then gnucash crashes.

that crash goes on you. You changed code in the import-export/hbci 
subdirectory, but haven't tested it AT ALL -- you can't, understandably: HBCI 
stuff can only be used by customers of German banks. Would you please in the 
future refrain from changing code that other users depend on, but where you 
can't test it at all?!? It turns out you got one FALSE errornously for a 
TRUE. Well, that can happen to anybody, but I'm quite upset that you 
introduced it in a part that you didn't test, and you also didn't take care 
that I review/test it quick enough. 

Why did you want to push your code into mine by all means? Because you wanted 
the HBCI code to use YOUR matcher GUI? By the way, introducing a user 
preference is a nice idea to force^H^H^H^H^H convince *me* testing your GUI, 
but it wouldn't have been necessary in the first place. I am quite aware of 
the fact that you are/have been still working on your importer GUI, and I 
have been looking at this regularly by your provided OFX sample files from 
libofx. Now why was it necessary to introduce non-trivial code that finally 
broke the HBCI module for two days?!? Did you think somebody's penis was not 
long enough already?!? If you've had waited some more days (well actually 
until right now), I would've had tested your code early enough and seen how 
the GUI is getting into the right direction. If you were so eager to have me 
try this in the HBCI context, you could as well have provided the necessary 
lines of code as comments in gnc-hbci-gettrans.c and told me which ones to 
uncomment. Gee. I don't get upset really that often, but this is one 
occasion. Hrmpf.

Now for the facts: A user preference about which "import matcher" to choose is 
a bad idea. This user preference should go away ASAP, since nobody except the 
two of us will understand it anyway. I'll leave it in there for the time 
being, but in 1.7.6 it should *not* exist anymore.

Your transaction importer looks quite nice now, and it's constantly improving. 
It is quite likely that I'll throw my transaction importer GUI away soon. But 
there are still some things that have yet to be fixed: The account 
matcher/picker still doesn't show an initial selection if the selected 
account is level-3 or higher (subaccount of a subaccount of a toplevel 
account). This needs to be fixed. The column headings "A" and ... (forgot the 
other) need to be i18n'd as well, but anyway I would prefer to have full 
words in them. I'm also not really happy with the wording of the 'import 
action' field since it shows a whole lot of information lumped together in 
one sentence, but I need to think&test that more.

Christian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iQCVAwUBPfeiNGXAi+BfhivFAQGh+AQAnNBx2H7BVAMvC+a+yDdEd/aJivNadp6r
fiaBHC76AXOVOGjCI5uGmjyFsIPYhXQ6AeWk7QFG25RfY2FZ4qlV/i2aeNgVH2vV
0ZKG/uq4ggZ3mqMRHDbE62Px+3xPN0GWiUg14H0s6VOfKAejT2oj/BvwanGo8WIe
X8gQxJF8gUI=
=/JxQ
-----END PGP SIGNATURE-----