Updated window-register [gnc-split-reg]; please test.

Josh Sled jsled@asynchronous.org
Sun, 3 Nov 2002 23:57:08 -0800


I've moved about half of the lines of window-register.c into
gnc-split-reg.c.  I've done something similar once before, but I never
removed the lines from window-register.c ... this does the seperation a
bit more cleanly, and _does_ remove those lines.

window-register is now implemented in terms of a gnc-split-reg widget, which
provides the GnucashRegister sheet, menu/toolbar/summarybar/popup and all
basic editing functionality.  The window-register is now responsible for
only the functionlity it adds, such as the date-based range limitation,
transfers, reconciliation, scrubbing, &c.  The SX-related uses of the
register now use gnc-split-reg instead of gnc-regWidget.

I took some care to make the split clean, but it was a long and painful
process.  Please exercise the register as fully as you have time to do,
and any bugs that come up can hopefully be addressed before the beta
next weekend.  There are still some known issues [see the list at the
top of gnc-split-reg.c], but almost everything that was working before
this commit should work identically afterwards.

Cheers...
...jsled

-- 
http://www.asynchronous.org - `a=jsled; b=asynchronous.org; echo ${a}@${b}`
jabber:jsled@jabber.asynchronous.org, ICQ:4983267, {AIM,YIM}:joshsled


----- Forwarded message from Joshua Sled <jsled@linas.org> -----

From: jsled@linas.org (Joshua Sled)
Subject: CVS update: gnucash/src/gnome
Date: Mon,  4 Nov 2002 01:46:55 -0600 (CST)
To: gnucash-patches@lists.gnucash.org


Date:	Monday November 4, 2002 @ 1:46
Author:	jsled

Update of /home/cvs/cvsroot/gnucash/src/gnome
In directory www.linas.org:/tmp/cvs-serv29001/src/gnome

Modified Files:
	Makefile.am dialog-scheduledxaction.c dialog-sxsincelast.c 
	window-register.c 
Added Files:
	gnc-split-reg.c gnc-split-reg.h 
Log Message:
2002-11-03  Joshua Sled  <jsled@asynchronous.org>

	* src/gnome/dialog-sxsincelast.c: Use GNCSplitReg over
	GNCRegWidget.

	* src/gnome/dialog-scheduledxaction.c
	(schedXact_editor_create_ledger): Use GNCSplitReg over
	GNCRegWidget.

	* src/gnome/glade/register.glade: Moved a bunch of the
	previously-shared widget definitions into seperate places to be
	accessed by window-register.c and gnc-split-reg.c.

	* src/gnome/window-register.c: Massive code-sucking into
	gnc-split-reg.c; this file now only handles the details of being
	the register window: dealing with dates and the extended menus and
	whatnot.

	* src/gnome/gnc-split-reg.c: Added; a better implementation of
	gnc-regWidget.  All the "common" register-editing code has been
	moved here from window-register.c.

	* src/register/ledger-core/gnc-regwidget.c: Removed; replaced with
	src/gnome/gnc-split-reg.c.

	* src/register/register-gnome/gnucash-date-picker.c
	(gnc_date_picker_new): Call gtk_widget_show_all rather than
	gtk_widget_realize in order to setup the calendar to a state
	sufficient for subsequent calls.

	* HACKING: Added description of how to start GnuCash in GDB.

_______________________________________________
gnucash-patches mailing list
gnucash-patches@lists.gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-patches


- ----- End forwarded message -----