Fixing Linas' turds (was Re: Compile Error with latest cvs)

[Derek Atkins]

linas at linas.org (Linas Vepstas) writes:

> Derek,
>
> You need to 
>
> make clean; make; make install

This is insufficient.  I tried with a clean checkout and it died
with the same error that Herbert reported.  Are you sure you're
not configuring with --disable-error-on-warning?

> The changes caused the sizes of various structures to change.
> The default auomake causes libs to be pulled from /usr/local/lib
> which will cause all sorts of weird core dumps, which is probably what
> you saw.

this is not what I saw.

> If there is a specific bug, let me know, but it builds cleanly
> for me, and I can use registers just fine after building. 
> I did not try the business part of gnucash, but have no reason
> to beleve anythign broke.

Wrong number of arguments to functions.. All over the damn place.

> --linas

-derek

> On Sun, Apr 18, 2004 at 03:40:56PM -0400, Derek Atkins was heard to remark:
>> Thanks.
>> 
>> Linas' changes to the engine from last night are just completely
>> broken.  Even after I fixed this problem I found a bunch of others
>> later on.  Even worse, his code started calling functions is additional
>> parameters, which is just illegal.
>> 
>> So I decided to revert his recent changes.  If you pull down CVS and
>> try again in a few minutes it should work again.  I'm just waiting for
>> my build/install to finish before I commit (the build has finished,
>> but not the install).
>> 
>> Linas: In the future PLEASE make sure the code actually BUILDS before
>> you commit!  Your "simple" change to QueryAccess resulted in a LOT of
>> other problems in many places in GnuCash.
>> 
>> -derek
>> 
>> Herbert Thoma <tma at iis.fhg.de> writes:
>> 
>> > Hi!
>> >
>> > I just updated and get the following error in the HEAD branch:
>> >
>> > gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../lib/libc -I../../src -I../../src/gnc-module -DGNUCASH -I/opt/gnome/include/glib-1.2 -I/opt/gnome/lib/glib/include -I /opt/gnucash/g-wrap-latest/include/g-wrap -g -O2 -Wall -Wunused -Wmissing-prototypes -Wmissing-declarations -Werror -MT Transaction.lo -MD -MP -MF .deps/Transaction.Tpo -c Transaction.c  -fPIC -o .libs/Transaction.o
>> > Transaction.c: In function `xaccSplitRegister':
>> > Transaction.c:3253: warning: initialization from incompatible pointer type
>> > Transaction.c:3255: warning: initialization from incompatible pointer type
>> > Transaction.c:3256: warning: initialization from incompatible pointer type
>> > Transaction.c:3257: warning: initialization from incompatible pointer type
>> > make[5]: *** [Transaction.lo] Fehler 1
>> > make[5]: Leaving directory `/opt/gnucash/gnucash_cvs/gnucash_work/src/engine'
>> > make[4]: *** [all-recursive]
>> >
>> >  Herbert.
>> > _______________________________________________
>> > gnucash-devel mailing list
>> > gnucash-devel at gnucash.org
>> > https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>> >
>> >
>> 
>> -- 
>>        Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
>>        Member, MIT Student Information Processing Board  (SIPB)
>>        URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
>>        warlord at MIT.EDU                        PGP key available
>> _______________________________________________
>> gnucash-devel mailing list
>> gnucash-devel at gnucash.org
>> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>
> -- 
> pub  1024D/01045933 2001-02-01 Linas Vepstas (Labas!) <linas at linas.org>
> PGP Key fingerprint = 8305 2521 6000 0B5E 8984  3F54 64A9 9A82 0104 5933
>
>

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available