CVS HEAD - trying to fix

Mon Nov 8 10:50:50 EST 2004

On Wednesday 03 November 2004 11:42 pm, you wrote:
> Neil Williams <linux at codehelp.co.uk> writes:
> > Do you want me to try fixing HEAD?
>
> yes, please.
>
> > I did try with a build that hasn't been updated since August 04 and I got
> > the same problem. Looks like it's been there a while and I just haven't
> > been testing that area. I've concentrated on druid-hierarchy etc., and
> > haven't needed to create new invoices in HEAD - until now.
>
> Few people use HEAD for much.  I know I dont.

So which branch do you use to test new code?
Which branch would you recommend I test the merge code against?

>
> -derek

The problems in CVS HEAD business objects are numerous.

Invoices are posted to the accounts with gnc_numeric_zero values, despite 
having an amount set in the entries.
Any business activity causes a blank customer entry to appear.
 The blank customer remains linked to the previous Job entry.
 The original customer now has NO job entries.
The blank customer does NOT exist in the XML data file, it is created during / 
just after start-up. 
Loading a working data file (created using v1.8.9) causes multiple blank 
customers to appear, all Job's are re-allocated to one or other blank 
customer but with no discernible pattern - jobs that were previously one of 
~50 for the same customer, get allocated to different spurious blank 
customers, some blanks get 12, some just one. The original customers never 
retain any.
Unposting an invoice also causes the BillTerm entries to become invalid AND 
unfixable in the GUI.
The dummy customer that is created has no billing address or other text fields 
set and has the currency set as ADF (the first one in the list).
Clicking the Invoice link in the Customer Report correctly loads the invoice 
with the real totals set, even though the report itself shows a zero amount, 
so the invoice itself remains valid.
I also get Orphan-GBP created in every file - old, working files as well as 
new - every time I view any account. I can see how Scrub.c creates the file, 
cannot see why it does so.
Payments also get reset to zero amounts, no trace of the original payment 
amount is stored.

The rest of the accounts and reports seem OK.

Even when working with a known working 1.8.9 GnuCash data file, posting an 
invoice posts a gnc_numeric zero, so it's not linked just to new files or 
badly configured accounts.

The GUID references appear correct and the entry amounts are saved correctly, 
but the splits are not copied:
      <split:value>0/100</split:value>
      <split:quantity>0/100</split:quantity>
  <entry:qty>74000000/1000000</entry:qty>
  <entry:i-price>280000/1000000</entry:i-price>

(This entry for 74 miles at 28p/mile in an invoice).

The patch to insert this line:
  ${top_builddir}/src/business/business-utils/libgncmod-business-utils.la \
into src/business/business-ledger/Makefile.am
is needed to build a usable CVS HEAD going back to checkout -D 2004-08-18, so 
this isn't a recent problem with HEAD. (It could go back further but that's 
the earliest tree I've built.) All the above problems are common to the 
current CVS HEAD and the HEAD tree from August. (I was hoping that building 
an earlier tree may have illuminated the source of the problems.)

I've tried to work out where the errors lie but this is going to take a week 
or two to fix. I now haven't got a usable version that doesn't suffer from 
these problems (as I can't build the 1-8 branch), which will make testing the 
import code awkward.

My remaining problems with my own code are:
1. AccountGroup - need to find a way to retain groups after a merge to 
complete the druid-merge code. Other improvements are also overdue for the 
main merge routines.
2. QofBook import - need to extend the merge from just new account trees to 
entire books.
3. QSF and the palm/pilot-link code. (I've got a working format that is 
properly namespaced and validated against a usable schema.)

I'll try and allocate some time to working on HEAD but I'm going to have to 
spend most of my time on #1 and #3 (with work on #2 following the solution of 
problem #1). I'll concentrate on how the merge operates with non-business 
objects and work on the business problems when I know that other parts are 
working.

-- 

Neil Williams
=============
http://www.codehelp.co.uk/
http://www.dclug.org.uk/
http://www.isbn.org.uk/
http://sourceforge.net/projects/isbnsearch/

http://www.biglumber.com/x/web?qs=0x8801094A28BCB3E3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20041108/55d411fc/attachment.bin