[Gnucash-changes] QOF/CashUtil Sync: Engine

[Derek Atkins]

Yet another comment...

Neil Williams <codehelp at cvs.gnucash.org> writes:

> diff -Lsrc/engine/gnc-numeric.c -Lsrc/engine/gnc-numeric.c -u -r1.26.4.7 -r1.26.4.8
> --- src/engine/gnc-numeric.c
> +++ src/engine/gnc-numeric.c
> @@ -33,7 +33,7 @@
>  #include <string.h>
>  
>  #include "gnc-numeric.h"
> -#include "qofmath128.c"
> +#include "qofmath128.h"

Why did you change this?  This was done this way for a reason,
to allow the compiler to optimize the 128-bit math functions
in the gnc-numeric object file.  By #including the .c file you
let the compiler optimize out the function calls, whereas if you
don't then it can't.

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available