[Gnucash-changes] QOF/CashUtil Sync: Engine

[Derek Atkins]

Quoting Neil Williams <linux at codehelp.co.uk>:

> On Wednesday 17 August 2005 1:24 pm, Derek Atkins wrote:
>> Neil Williams <codehelp at cvs.gnucash.org> writes:
>> > diff -Lsrc/engine/gnc-numeric.c -Lsrc/engine/gnc-numeric.c -u -r1.26.4.7
>> > -r1.26.4.8 --- src/engine/gnc-numeric.c
>> > +++ src/engine/gnc-numeric.c
>> > @@ -33,7 +33,7 @@
>> >  #include <string.h>
>> >
>> >  #include "gnc-numeric.h"
>> > -#include "qofmath128.c"
>> > +#include "qofmath128.h"
>>
>> Why did you change this?  This was done this way for a reason,
>> to allow the compiler to optimize the 128-bit math functions
>> in the gnc-numeric object file.  By #including the .c file you
>> let the compiler optimize out the function calls, whereas if you
>> don't then it can't.
>
> If it is included, does it have to also go into the distribution and include
> directory?

Into the DIST? yes.  Into the install/include dir?  no.  I.e., you need to
include the files in the tarball during "make dist", but they don't need to be
installed during "make install".

> I wanted to change it so that qofmath128.h is put into qof/include, not the C
> file - (if indeed the h file needs to be there at all.)

Nothing should need access to qofmath128.[ch] except gnc_numeric.  Is 
there any
reference outside gnc_numeric.c?  I certainly don't see anything.  There's no
need to release qofmath128.h to anyone; it's not a public API.  At least I see
no reason to MAKE it a public API.

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available