Attention to bug 170444

Thomas Bushnell BSG tb at becket.net
Sun Aug 28 23:16:04 EDT 2005


Derek Atkins <warlord at MIT.EDU> writes:

> Any reason not to change this to remove the goto?  We could just 
> reorder the two
> case statements and change the code from:
>
>  if (n == 0)
>    goto iso_date;
>  }
>  break;
>
> to...
>
>  if (n != 0)
>    break;
>  }
>  /* FALLTHROUGH */

Looks equivalent to me.

> I'll try to apply this to 1.8 and g2 either tonight or, more likely,
> tomorrow.

Timing doesn't matter from my end; I've made the change already in
Debian.

How about an audit of the other uses of strftime?




More information about the gnucash-devel mailing list