Attention to bug 170444

Derek Atkins warlord at MIT.EDU
Sun Aug 28 23:18:47 EDT 2005


We should probably have one gnucash API that calls strftime() and have 
all other
places just call the gnc api.

-derek

Quoting Thomas Bushnell BSG <tb at becket.net>:

> Derek Atkins <warlord at MIT.EDU> writes:
>
>> Any reason not to change this to remove the goto?  We could just
>> reorder the two
>> case statements and change the code from:
>>
>>  if (n == 0)
>>    goto iso_date;
>>  }
>>  break;
>>
>> to...
>>
>>  if (n != 0)
>>    break;
>>  }
>>  /* FALLTHROUGH */
>
> Looks equivalent to me.
>
>> I'll try to apply this to 1.8 and g2 either tonight or, more likely,
>> tomorrow.
>
> Timing doesn't matter from my end; I've made the change already in
> Debian.
>
> How about an audit of the other uses of strftime?
>
>
>



-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available



More information about the gnucash-devel mailing list