[Gnucash-changes] r11993 - gnucash/branches/goffice-update - Fix unnecessary subdirectory handling of config headers

[Neil Williams]

On Sunday 20 November 2005 8:45 pm, Derek Atkins wrote:
> Quoting Neil Williams <codehelp at cvs.gnucash.org>:
> > gnucash/branches/goffice-update/lib/goffice-0.0.4/goffice-plugins.mk	2005
> >-11-20 20:33:25 UTC (rev 11993)
> > @@ -1,5 +1,6 @@
> > AM_CPPFLAGS = \
> > -    -I$(top_srcdir)/lib/goffice-0.0.4		\
> > +    -I$(top_srcdir)/lib/libgsf-1.12.3	    \
> > +    -I$(top_srcdir)/lib/goffice-0.0.4 		\
> >     -I$(top_builddir)/lib/goffice-0.0.4		\
> >     $(GOFFICE_DEPS_CFLAGS)
>
> Umm... This seems to assume that we're always building the internal
> goffice with the internal libgsf.  Are you sure that's the case?  Isn't
> it possible to have a platform that has libgsf but not libgoffice?
>
> Shouldn't we just have a LIBGSF_INCS defined by configure that we supply
> in the goffice build?

Ah. Yes. Missed that one.

No time to do that tonight myself, but if it's still outstanding tomorrow I'll 
fix it then.

Whilst it's in the remit, do we need:
> >     -I$(top_builddir)/lib/goffice-0.0.4		\
as well as
> > +    -I$(top_srcdir)/lib/goffice-0.0.4 		\

?
Which is better?

-- 

Neil Williams
=============
http://www.data-freedom.org/
http://www.nosoftwarepatents.com/
http://www.linux.codehelp.co.uk/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20051120/67940cb4/attachment.bin