[Gnucash-changes] r11993 - gnucash/branches/goffice-update - Fix unnecessary subdirectory handling of config headers

[Derek Atkins]

Quoting Neil Williams <codehelp at cvs.gnucash.org>:

> gnucash/branches/goffice-update/lib/goffice-0.0.4/goffice-plugins.mk	2005-11-20 19:03:18 UTC (rev 
> 11992)
> +++ 
> gnucash/branches/goffice-update/lib/goffice-0.0.4/goffice-plugins.mk	2005-11-20 20:33:25 UTC (rev 
> 11993)
> @@ -1,5 +1,6 @@
> AM_CPPFLAGS = \
> -    -I$(top_srcdir)/lib/goffice-0.0.4		\
> +    -I$(top_srcdir)/lib/libgsf-1.12.3	    \
> +    -I$(top_srcdir)/lib/goffice-0.0.4 		\
>     -I$(top_builddir)/lib/goffice-0.0.4		\
>     $(GOFFICE_DEPS_CFLAGS)

Umm... This seems to assume that we're always building the internal
goffice with the internal libgsf.  Are you sure that's the case?  Isn't
it possible to have a platform that has libgsf but not libgoffice?

Shouldn't we just have a LIBGSF_INCS defined by configure that we supply
in the goffice build?

-derek
-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available