Automake warnings in lib/goffice on Debian

[Neil Williams]

On Friday 02 September 2005 10:27 pm, David Hampton wrote:
> Log Message:
> -----------
> Automake doesn't cause warnings in lib/goffice any more, so remove
> the message telling the user to ignore them.

:-(

The underlying changes in the dependencies of goffice mean that this is not 
true for Debian unstable and these changes will trickle down into other 
distributions in time.

I'm re-instating the CFLAGS changes *locally* as I cannot build goffice 
without -Wno-error in certain directories below lib/goffice. Some files 
generate dozens of warnings like:
gog-error-bar.c:349: warning: pointer targets in assignment differ in 
signedness
gog-style.c:1409: warning: pointer targets in passing argument 1 of 'strlen' 
differ in signedness
gog-object-xml.c:428: warning: pointer targets in passing argument 2 of 
'g_object_class_list_properties' differ in signedness
gog-style.c:861: warning: unused variable 'w'
gog-style.c:1181: warning: pointer targets in initialization differ in 
signedness
gog-renderer-svg.c:413: warning: pointer targets in passing argument 3 of 
'xmlNewDocNode' differ in signedness

I've already had to make allowances for macros that have changed the number of 
arguments - those errors can't be ignored so I've rewritten the C and omitted 
those files from the patch that generates the commit.

The rest of GnuCash now builds with -Werror - the gwrap problems appear fixed.

I've had to add CFLAGS += -Wno-error to graph/Makefile.am, utils/Makefile.am, 
gui-utils/Makefile.am, split/widgets/Makefile.am, split/Makefile.am and 
goffice/Makefile.am itself.

The full list of files that had to be changed to build is:
 --exclude gog-axis.c --exclude gog-style.c --exclude gog-label.c \
 --exclude gog-series.c --exclude gog-error-bar.c \
 --exclude command-context-stderr.c --exclude io-context.c \
 --exclude gnc-html-graph-gog.c --exclude gnc-plugin.c \
 --exclude graph/Makefile.am --exclude utils/Makefile.am \
 --exclude gui-utils/Makefile.am --exclude split/widgets/Makefile.am \
 --exclude split/Makefile.am --exclude goffice/Makefile.am \

Quite what this might mean for the stability of the coopted goffice code in G2 
on Debian I'm not sure.

Plus, it's by no means assured that there won't be more files to add to that 
list in time.

-- 

Neil Williams
=============
http://www.data-freedom.org/
http://www.nosoftwarepatents.com/
http://www.linux.codehelp.co.uk/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20050916/08b6feb3/attachment.bin