[Gnucash-changes] r12296 - gnucash/trunk/src/gnome-utils - Fix gnc-svninfo.h rule for gentoo ebuild where svn is no longer available

[Derek Atkins]

Hi,

Christian Stimming <cstim at cvs.gnucash.org> writes:

> Log:
> Fix gnc-svninfo.h rule for gentoo ebuild where svn is no longer available 
>
> Modified: gnucash/trunk/src/gnome-utils/Makefile.am
> ===================================================================
> --- gnucash/trunk/src/gnome-utils/Makefile.am	2006-01-08 14:01:14 UTC (rev 12295)
> +++ gnucash/trunk/src/gnome-utils/Makefile.am	2006-01-08 14:24:27 UTC (rev 12296)
> @@ -273,7 +273,7 @@
>  		echo "/* Autogenerated. Do not change. */" > _gnc-svninfo.h ; \
>  		echo "#define GNUCASH_SVN_REV \"$$svninfo\"" >> _gnc-svninfo.h ; \
>  	else \
> -		cp $(srcdir)/gnc-svninfo.h _gnc-svninfo.h ; \
> +		echo "#define GNUCASH_SVN_REV \"unknown\"" > _gnc-svninfo.h ; \
>  	fi

I'm not sure exactly what the problem is that you're trying to fix,
but this is not the correct solution.  The issue appears to be that
you have an SVN checkout but no "svn" when you build?  Is that what's
going on?

The intended behavior was to build gnc-svninfo.h during 'make dist'
and then when you build from the tarball you know what SVN version
you've got in the resultant binary.   This particular change breaks
that behavior.

I want to revert it, but I don't know what the ebuild is doing or
how it's failing....  All I do know is that this patch is wrong
regardless of the original issue.

-derek
-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available