[PATCH] Updated add/edit account window

Chris Shoemaker c.shoemaker at cox.net
Thu Jan 19 14:55:05 EST 2006


On Thu, Jan 19, 2006 at 08:19:14PM +0100, Eskil Bylund wrote:
> > Only that the static tree model probably shouldn't contain selection
> > state.  It might be shared by multiple views that want different
> > selections.
> >
> No, of course. See above.
> 
> > Maybe that's why you wanted to provide the treemodel as an argument?
> > So you could filter the non-static treemodels?
> >
> Yes. Currently there are no non-static treemodels that will be
> filtered, but I added it just in case.
> 
> To summarize above: I would like to remove the GtkTreeView specific
> functions from the model and make the Filter dialog use its own model
> for storing selection state.

It would definitely be nice to show selection state with checkboxes.
But it'd also be nice to use the static account types tree model.

What do you think about this:?

Keep the selection state private to the filterBy dialog instead of
using a new tree model for each dialog.  You can even put that
selection state right into a new field in the AccountFilterDialog struct.

Instead of using an attribute mapping to the checkbox's treeviewcolumn
from the new model's selection-state column, use a GtkTreeCellDataFunc
that updates the "active" property of the GtkCellRendererToggle from
that private selection state field.  Then the filterBy dialog can
always use the static treemodel.

-chris



More information about the gnucash-devel mailing list