[PATCH] Updated add/edit account window

Derek Atkins warlord at MIT.EDU
Thu Jan 19 15:01:46 EST 2006


Quoting Chris Shoemaker <c.shoemaker at cox.net>:

>> To summarize above: I would like to remove the GtkTreeView specific
>> functions from the model and make the Filter dialog use its own model
>> for storing selection state.
>
> It would definitely be nice to show selection state with checkboxes.
> But it'd also be nice to use the static account types tree model.
>
> What do you think about this:?
>
> Keep the selection state private to the filterBy dialog instead of
> using a new tree model for each dialog.  You can even put that
> selection state right into a new field in the AccountFilterDialog struct.
>
> Instead of using an attribute mapping to the checkbox's treeviewcolumn
> from the new model's selection-state column, use a GtkTreeCellDataFunc
> that updates the "active" property of the GtkCellRendererToggle from
> that private selection state field.  Then the filterBy dialog can
> always use the static treemodel.

I'm not sure why we need multiple account-type tree models.  There's only
one set of account types in the system.  Granted, these types are filtered
for display in different ways based upon the context, but I dont see what
multiple models buys us here.

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available



More information about the gnucash-devel mailing list