r12977 - gnucash/trunk/src - Re-enable report menu setup.

[Chris Shoemaker]

On Thu, Jan 26, 2006 at 10:15:54AM +0100, Christian Stimming wrote:
> Hi Chris,
> 
> thanks for going through all this gory init code :-)

n.p.  I figured it had to be done sooner or later and that code wasn't
getting any prettier with age.

> 
> Since you touched the report loading code: 

Just to clarify: so far, I haven't really changed the report loading
code, just the generation of the report _menus_.  But, I think the
report system is now officially cruftier than the application startup
process.  So, I _am_ looking at touching the report loading code right
now.

<slight tangent> The real issue is that there's some design confusion
between report _generation_ and report _management_.  Leaving the
report management in guile is not very compatible with the new
"C-program-with-libguile" architecture.  I hope to extract report
_management_ from guile in two or three steps (maybe more, hard to
say).  I can already envision what the C-libguile interface looks like
and it's much clearer than the current state.  One small fringe
benefit that somebody might care about (not really me) is that it
should become quite trivial to save and restore reports into separate
windows - something that's practically impossible now.  But that's
insignificant compared to the maintainability improvement that comes
from clear abstractions. <end tangent>

> Have you been able to 
> reproduce the bug "SVN crashes on opening 1.8 datafile with renamed 
> reports" http://bugzilla.gnome.org/show_bug.cgi?id=326578 ? Are you able 
> to reproduce it now? Or is it likely that this bug has also been fixed 
> by your improvements in the report loading code?

It's unlikely to have been fixed accidentally, but I'll try to reproduce.

-chris