[Gnucash-changes] r14497 - gnucash/trunk - Minor cleanup of configure.in.

Derek Atkins warlord at MIT.EDU
Sat Jul 15 12:14:10 EDT 2006


Just an FYI....

Chris Shoemaker <chris at cvs.gnucash.org> writes:

>      PKG_CHECK_MODULES(GTKHTML, libgtkhtml-3.8 , [gtkhtml=1] , [gtkhtml=0])
> -    if test $gtkhtml = 0
> +    if test x$gtkhtml = x0
>        then
>      	PKG_CHECK_MODULES(GTKHTML, libgtkhtml-3.6 , [gtkhtml=1] , [gtkhtml=0])
> -    	if test $gtkhtml = 0
> +    	if test x$gtkhtml = x0
>      	  then
>      	     PKG_CHECK_MODULES(GTKHTML, libgtkhtml-3.2 , [gtkhtml=1] , [gtkhtml=0])
> -    	     if test $gtkhtml = 0
> +    	     if test x$gtkhtml = x0

These changes are not required.  The "gtkthml" variable CANNOT be
unset/null in any case here.  It will ALWAYS be either 0 or 1.

>      	       then 
>      	          PKG_CHECK_MODULES(GTKHTML, libgtkhtml-3.1 , [gtkhtml=1],
>                                      AC_MSG_ERROR([Could not find a working gtkhtml version (need 3.1, 3.2, 3.6, or 3.8)]))
> @@ -1115,7 +1116,7 @@
>      
>      AC_ARG_ENABLE( efence,
>        [  --enable-efence               link using efence],
> -      if test $enableval = yes; then
> +      if test x$enableval = xyes; then

I think that autoconf guarantees that enableval is set to something
at all times.  I don't think it can be unset/null.  So I don't think this
change is necessary, either (or the other places where enableval
is modifies).

>           EFENCE_LIBS="-lefence"
>           USE_EFENCE=1
>  	 AC_DEFINE(USE_EFENCE,,We are using EFence)
> @@ -1266,12 +1267,12 @@
>    PKG_CHECK_MODULES(LIBGSF, $libgsf_reqs)
>    
>    AC_CHECK_DECL(fdopen, fdopen_works=yes, fdopen_works=no)
> -  if test $fdopen_works = no ; then
> +  if test x$fdopen_works = xno ; then

Just like the gtkhtml above, fdopen_works is guaranteed to have a value.
So again, this change isn't needed here (or below, snipped).

>    		struct_timeval_works=yes,
>    		struct_timeval_works=no)
> -  	test $struct_timeval_works = yes && break
> +  	test x$struct_timeval_works = xyes && break

Same thing, different variable.

[snip]

Lots of other changes are just not required because the variables are
guaranteed to be set...  But no reason to revert, either, because it
doesn't HURT anything to keep them this way.  But it just seems silly
to make changes that aren't required.  "If it aint broke..."

-derek
-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available


More information about the gnucash-devel mailing list