r13462 - gnucash/trunk/src/engine - Remove xaccAccountRemoveSplit, and xaccAccountInsertSplit.

[Derek Atkins]

Chris,

You need to fix the scheme, too.   There are a number of places
in the code in scheme that still use/assume the old API.  Just as
an example:

[warlord at cliodev src]$ find . -name \*.scm | xargs grep gnc:account-insert-split
./src/engine/gw-engine-spec.scm: 'gnc:account-insert-split
./src/engine/engine-interface.scm:                (gnc:account-insert-split account split)
./src/import-export/qif-import/qif-to-gnc.scm:                   (gnc:account-insert-split far-acct gnc-far-split)
./src/import-export/qif-import/qif-to-gnc.scm:          (gnc:account-insert-split near-acct gnc-near-split))
./src/import-export/qif-import/qif-to-gnc.scm:                (gnc:account-insert-split near-acct gnc-near-split)
./src/import-export/qif-import/qif-to-gnc.scm:                (gnc:account-insert-split far-acct gnc-far-split)
./src/import-export/qif-import/qif-to-gnc.scm:                      (gnc:account-insert-split commission-acct
./src/import-export/qif-io-core/qif-bank-xtn-import.scm:        (gnc:account-insert-split acct split)
./src/import-export/qif-io-core/qif-invst-xtn-import.scm:        (gnc:account-insert-split acct split)

-derek

Chris Shoemaker <chris at cvs.gnucash.org> writes:

> Author: chris
> Date: 2006-03-03 19:11:44 -0500 (Fri, 03 Mar 2006)
> New Revision: 13462
> Trac: http://svn.gnucash.org/trac/changeset/13462
>
> Modified:
>    gnucash/trunk/src/engine/Account.c
>    gnucash/trunk/src/engine/Account.h
>    gnucash/trunk/src/engine/AccountP.h
> Log:
>    Remove xaccAccountRemoveSplit, and xaccAccountInsertSplit.
>    (Actually, xaccAccountInsertSplit is #def'd to xaccSplitSetAccount().)
>    Accounts no longer manage their Split lists.  The Account split lists
>    should only ever be modified from within xaccTransCommitEdit().  This
>    simplifies some of the operations on Accounts, since they can now be 
>    expressed in terms of operations on Splits.
>
>    Also, the consolidation of two operations (RemoveSplit and InsertSplit) 
>    into one operation (xaccSplitSetAccount) means that it's no longer 
>    possible to orphan a Split.
>
>    Incidental:
>       Fix a leak of a KVP frame.
>       Don't recompute the account balance if we're shutting down.

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available