quickfill problem in register fixed in r13488

[Christian Stimming]

Hi Chris,

(sorry for answering to myself) the issue with the quickfill in Basic Ledger 
mode is fixed once the uninitialized variables are correctly initialized, 
r13488.

What is left are these compiler warnings, my request about distinguishing 
assignments from loop conditions, AND your ChangeLog entries! *sigh*!!! Do we 
need to apply the rules from README.svn before you stick to our current 
convention? Come on. You know how this works.

Christian

Am Sonntag, 5. März 2006 09:43 schrieb Christian Stimming:
> And: Your changes cause a bunch of compiler warnings, copied below, which
> need to be fixed before 1.9.2, too. The ones with "uninitialized value" are
> actually a real bug, I guess.
>
> The ones about "assignment used as truth value" are rather annoying - I
> would specifically ask you *not* to use assignments as boolean values in
> loops. As we all know, this is a very common error for beginners in C, and
> because of that reason, everyone who reads this code later will first spend
> some time asking herself "is this really intended or is this rather this
> well-known beginner error"? Just to avoid any confusion here, I would
> kindly ask you to make the assignment and the loop condition separate
> expressions.
>
> And in general I'm confused as to why these compiler warnings didn't cause
> an error at your place. This is gcc-3.3.5 here, but that shouldn't make a
> difference. Did you configure with --disable-error-on-warning? We would ask
> you *not* to do so, as it is precisely this kind of commit problem that is
> caused by disabling the errors on warning.
>
> By the way, the loading of the data file still seems to be slower by
> approx. a factor of two, compared to the r13444 build as of mid this week.
>
> Christian
>
>
> Compile warnings:
>
> split-register.c: In function `gnc_trans_split_index':
> split-register.c:83: warning: suggest parentheses around assignment used as
> truth value
> split-register.c: In function
> `gnc_split_register_empty_current_trans_except_split':
> split-register.c:1085: warning: suggest parentheses around assignment used
> as truth value
>
> split-register-control.c: In function `gnc_find_split_in_trans_by_memo':
> split-register-control.c:463: warning: suggest parentheses around
> assignment used as truth value
> split-register-control.c: In function `gnc_split_register_auto_completion':
> split-register-control.c:703: warning: suggest parentheses around
> assignment used as truth value
>
> split-register-load.c: In function `gnc_split_register_load':
> split-register-load.c:418: warning: suggest parentheses around assignment
> used as truth value