exchange dialog window stopped working in r8979

[Bengt Thuree]

Hi

Regarding bug 335101 (http://bugzilla.gnome.org/show_bug.cgi?id=335101)

I managed (by brute force) to narrow it down

1.8.4 Build 8978 - Exchange window is     working
1.8.4 Build 8979 - Exchange window is NOT working


Diff between 78 and 79's changelog indicates that a change was made to not
run the exchange-rate dialog during certain circumstances. Perhaps this
change needs some review?

<       * src/register/ledger-core/split-register-control.c: if the exchange
<         rate cell is 0 but this is NOT the blank split, then don't run
<         the exchange-rate dialog unless specifically requested.



full diff below
$ diff r8979/ChangeLog r8978/ChangeLog
12,28d11
<       Support "gain/loss" balancing splits on stocks:
<       * src/engine/Transaction.c: fix xaccSplitGetPrice() to return '0'
<         if 'amount' is zero but 'value' is non-zero
<       * src/register/ledger-core/split-register-model-save.c: if we've
<         already handled the debcred cell then DON'T handle the price cell
<         as it will override the debcred's value.
<       * src/register/ledger-core/split-register.c: if #shares == 0,
<         price == 0, and value (buy/sell) != 0 then allow this entry;
<         it's an income/expense balancing split.
<       * src/register/ledger-core/split-register-control.c: if the exchange
<         rate cell is 0 but this is NOT the blank split, then don't run
<         the exchange-rate dialog unless specifically requested.
<       * src/register/ledger-core/split-register-model.c: when trying to
<         find the conversion rate for a split, remember if we found
<         a matching split (even if the amount is 0).  If all matching
<         splits are 0, then return 0, not 1.


-- 
Bengt Thuree   bengt at thuree.com    www.thuree.com/bt