[Gnucash-changes] r13716 - gnucash/trunk/src - factor out grammar check, add tests.

[Chris Shoemaker]

On Thu, Mar 30, 2006 at 03:59:39PM -0500, Joshua Sled wrote:
> Author: jsled
> Date: 2006-03-30 15:59:38 -0500 (Thu, 30 Mar 2006)
> New Revision: 13716
> Trac: http://svn.gnucash.org/trac/changeset/13716
> 
> Modified:
>    gnucash/trunk/src/app-utils/test/test-exp-parser.c
>    gnucash/trunk/src/calculation/expression_parser.c
> Log:
> factor out grammar check, add tests.
> 
> -  add_fail_test( "\"asdf\" + 0", NULL, 0 );
> +  // This used to work before the 334811, 308554 fixes... :/
> +  //add_fail_test( "\"asdf\" + 0", NULL, 0 );

I _really_ don't see the point in commenting out failing tests.  A
test file that passes on known buggy code is buggy itself.  It hides
the bug and wastes developer time.  If it fails everytime, I want to
_see_ it fail everytime.  That's the chief purpose of the test.  If
you plan on leaving it failing for a long time and don't want it to
break a 'make check', just don't let the failed case affect the exit
value, but please let it print FAILED.

A correctly failing test case is GOOD; it's the _only_ reason we write
them.

-chris

p.s. BTW, just a simple "a 0" (no quotes) shows the bug, too.