[Gnucash-changes] r13716 - gnucash/trunk/src - factor out grammar check, add tests.

[Josh Sled]

On Thu, 2006-03-30 at 16:28 -0500, Chris Shoemaker wrote:
> value, but please let it print FAILED.

While it would be nice if our test framework supported tests known not
to pass, it doesn't.  While I agree with you in the abstract, I disagree
in this case: I'd rather have a commented-out test and a passing `make
check` than failing tests that aren't really failing.  Note that that's
partly justified by the frequency of this failure condition (rare) and
impact (minimal).  We could and should extend our test framework to
support such tests, but until we do, commented out is better, imho.

In any case, I fixed the underlying problem, so the test has been
re-enabled.


> A correctly failing test case is GOOD; it's the _only_ reason we write
> them.

Yeah, of course.  This is an incorrectly failing test case.


> p.s. BTW, just a simple "a 0" (no quotes) shows the bug, too.

No, the problem is specifically with quoted strings.  See the tests on
lines 131..136, which do pass.

-- 
...jsled
http://asynchronous.org/ - `a=jsled; b=asynchronous.org; echo ${a}@${b}`