[Gnucash-changes] r14081 - gnucash/trunk - Use localtime_r only when HAVE_LOCALTIME_R is defined. Might be undefined on some weird systems out there, e.g. windows/mingw32.

[Christian Stimming]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Derek Atkins schrieb:
> Christian,
>> +	* lib/libqof/qof/gnc-date.c (timespecCanonicalDayTime)
>> +	(qof_print_date_buff, dateSeparator, gnc_timespec_last_mday)
>> +	(gnc_timespec2dmy): Use localtime_r only when HAVE_LOCALTIME_R is
>> +	defined. Might be undefined on some weird systems out there,
>> +	e.g. windows/mingw32.
> 
> Um, localtime_r should exist on all platforms, because we use
> AC_REPLACE_FUNCS(localtime_r)..  So if it doesn't exist natively
> then we supply our own implementation.   So this patch shouldn't
> be needed.
> 
> Did you make this change because it failed to build?  Or did you
> make this change because you THOUGHT it wasn't going to build but
> didn't verify that it failed?

Oh, we have AC_REPLACE_FUNCS here? Right, I didn't verify a failure, I
only thought this might come up and therefore I chose to implement it
right away while I still thought about it. Checking again I realize
localtime_r has never been a problem (no test box at hand ATM). So I
guess r14081 can be outright reverted.

Christian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQCVAwUBRGn1XWXAi+BfhivFAQIltwP+P/6od1gH/OuhyWOCCJKmKthg+o6vWpA9
ivD7yLMPRUQvz9eg+PxaM7/16mDkTlesRxxTczDwXiIgXhrrdMZ9Lt5ry1oqbNX4
KoxZp+nAFqM3fuEiLaS1sAkNLh9GhKPPNxRfJWyV6whpHGIvldU6FMXlGopPwoe2
pAswooOhXcI=
=9n5u
-----END PGP SIGNATURE-----